| Message ID | 1448983191-11932-1-git-send-email-clg@fr.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On 12/01/2015 08:49 PM, Cédric Le Goater wrote: > The patch corrects the order of the timestamp and manuf_id > attributes, which currently are reversed from what is stated > in the specs. (32. SEL Record Formats) > > We don't use them in skiboot so there should not be any > consequences. This is mostly for the records and for qemu > powernv. Good catch. > > Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > > The AMI document is wrong on that topic. At least the doc I referred is correct. -Vasant > > hw/ipmi/ipmi-sel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: skiboot.git/hw/ipmi/ipmi-sel.c > =================================================================== > --- skiboot.git.orig/hw/ipmi/ipmi-sel.c > +++ skiboot.git/hw/ipmi/ipmi-sel.c > @@ -117,8 +117,8 @@ struct oem_sel { > /* SEL header */ > uint8_t id[2]; > uint8_t type; > - uint8_t manuf_id[3]; > uint8_t timestamp[4]; > + uint8_t manuf_id[3]; > /* OEM SEL data (6 bytes) follows */ > uint8_t netfun; > uint8_t cmd; >
Cédric Le Goater <clg@fr.ibm.com> writes: > The patch corrects the order of the timestamp and manuf_id > attributes, which currently are reversed from what is stated > in the specs. (32. SEL Record Formats) > > We don't use them in skiboot so there should not be any > consequences. This is mostly for the records and for qemu > powernv. > > Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> > --- > > The AMI document is wrong on that topic. > > hw/ipmi/ipmi-sel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) THanks! Merged to master as of c41ea67f3ea56da03255ee8d2cddd018a064ed0c
Index: skiboot.git/hw/ipmi/ipmi-sel.c =================================================================== --- skiboot.git.orig/hw/ipmi/ipmi-sel.c +++ skiboot.git/hw/ipmi/ipmi-sel.c @@ -117,8 +117,8 @@ struct oem_sel { /* SEL header */ uint8_t id[2]; uint8_t type; - uint8_t manuf_id[3]; uint8_t timestamp[4]; + uint8_t manuf_id[3]; /* OEM SEL data (6 bytes) follows */ uint8_t netfun; uint8_t cmd;
The patch corrects the order of the timestamp and manuf_id attributes, which currently are reversed from what is stated in the specs. (32. SEL Record Formats) We don't use them in skiboot so there should not be any consequences. This is mostly for the records and for qemu powernv. Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> --- The AMI document is wrong on that topic. hw/ipmi/ipmi-sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)