Message ID | 1447740435-25617-1-git-send-email-stewart@linux.vnet.ibm.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C4E4214031F for <incoming@patchwork.ozlabs.org>; Tue, 17 Nov 2015 17:07:35 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id AA92F1A03A0 for <incoming@patchwork.ozlabs.org>; Tue, 17 Nov 2015 17:07:35 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0B64B1A003F for <skiboot@lists.ozlabs.org>; Tue, 17 Nov 2015 17:07:31 +1100 (AEDT) Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <skiboot@lists.ozlabs.org> from <stewart@linux.vnet.ibm.com>; Mon, 16 Nov 2015 23:07:30 -0700 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Nov 2015 23:07:28 -0700 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: stewart@linux.vnet.ibm.com X-IBM-RcptTo: skiboot@lists.ozlabs.org Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 7B92319D8041 for <skiboot@lists.ozlabs.org>; Mon, 16 Nov 2015 22:55:35 -0700 (MST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAH63vrs4456862 for <skiboot@lists.ozlabs.org>; Mon, 16 Nov 2015 23:03:57 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAH67ROt013698 for <skiboot@lists.ozlabs.org>; Mon, 16 Nov 2015 23:07:27 -0700 Received: from oc8180480414.ibm.com ([9.83.5.151]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id tAH67IWO013276; Mon, 16 Nov 2015 23:07:26 -0700 Received: from ka1.ozlabs.ibm.com (localhost [127.0.0.1]) by oc8180480414.ibm.com (Postfix) with ESMTP id 424AD2B85; Tue, 17 Nov 2015 17:07:17 +1100 (AEDT) From: Stewart Smith <stewart@linux.vnet.ibm.com> To: skiboot@lists.ozlabs.org Date: Tue, 17 Nov 2015 17:07:15 +1100 Message-Id: <1447740435-25617-1-git-send-email-stewart@linux.vnet.ibm.com> X-Mailer: git-send-email 2.1.4 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15111706-0017-0000-0000-00000F9256BB Subject: [Skiboot] [PATCH] lpc-rtc: zero out struct tm before read X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
diff --git a/hw/lpc-rtc.c b/hw/lpc-rtc.c index 63124dfe79fb..95506cd10e40 100644 --- a/hw/lpc-rtc.c +++ b/hw/lpc-rtc.c @@ -119,6 +119,8 @@ static void lpc_init_time(void) struct tm tm; bool valid; + memset(&tm, 0, sizeof(tm)); + lock(&rtc_lock); /* If update is in progress, wait a bit */
Picked up by static analysis. Never in a billion years would this affect the real world. Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- hw/lpc-rtc.c | 2 ++ 1 file changed, 2 insertions(+)