From patchwork Mon Jul 20 09:01:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Kerr X-Patchwork-Id: 497604 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ADD9140DBC for ; Mon, 20 Jul 2015 19:01:51 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 1FBB61A0CEC for ; Mon, 20 Jul 2015 19:01:51 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id A841A1A0A23 for ; Mon, 20 Jul 2015 19:01:47 +1000 (AEST) Received: by ozlabs.org (Postfix, from userid 1023) id 9190014077A; Mon, 20 Jul 2015 19:01:47 +1000 (AEST) MIME-Version: 1.0 Message-Id: <1437382901.87427.962791670608.2.gpush@pablo> In-Reply-To: <1437382901.86573.37557308684.0.gpush@pablo> To: skiboot@lists.ozlabs.org From: Jeremy Kerr Date: Mon, 20 Jul 2015 17:01:41 +0800 Subject: [Skiboot] [RFC, PATCH 2/4] core/mem_region: Move reserved-ranges parsing into a separate function X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel M Crowell Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" This change moves the property-style reserved-memory parsing code to a separate function. We no longer need to defer the dt_del_property() calls, so we can include them in the function, before dropping the mem_region_lock. Signed-off-by: Jeremy Kerr --- core/mem_region.c | 76 +++++++++++++++++++++++++--------------------- 1 file changed, 42 insertions(+), 34 deletions(-) diff --git a/core/mem_region.c b/core/mem_region.c index 48fdd7d..fede263 100644 --- a/core/mem_region.c +++ b/core/mem_region.c @@ -798,10 +798,50 @@ void adjust_cpu_stacks_alloc(void) skiboot_cpu_stacks.len = (cpu_max_pir + 1) * STACK_SIZE; } +static void mem_region_parse_reserved_properties(void) +{ + const struct dt_property *names, *ranges; + struct mem_region *region; + + names = dt_find_property(dt_root, "reserved-names"); + ranges = dt_find_property(dt_root, "reserved-ranges"); + if (names && ranges) { + const uint64_t *range; + int n, len; + + range = (const void *)ranges->prop; + + for (n = 0; n < names->len; n += len, range += 2) { + char *name; + + len = strlen(names->prop + n) + 1; + name = strdup(names->prop + n); + + region = new_region(name, + dt_get_number(range, 2), + dt_get_number(range + 1, 2), + NULL, REGION_HW_RESERVED); + list_add(®ions, ®ion->list); + } + } else if (names || ranges) { + prerror("Invalid properties: reserved-names=%p " + "with reserved-ranges=%p\n", + names, ranges); + abort(); + } else { + return; + } + + /* We generate the reservation properties from our own region list, + * which now includes the existing data. + */ + dt_del_property(dt_root, (struct dt_property *)names); + dt_del_property(dt_root, (struct dt_property *)ranges); +} + /* Trawl through device tree, create memory regions from nodes. */ void mem_region_init(void) { - const struct dt_property *names, *ranges; struct mem_region *region; struct dt_node *i; @@ -861,42 +901,10 @@ void mem_region_init(void) } /* Add reserved ranges from the DT */ - names = dt_find_property(dt_root, "reserved-names"); - ranges = dt_find_property(dt_root, "reserved-ranges"); - if (names && ranges) { - const uint64_t *range; - int n, len; - - range = (const void *)ranges->prop; - - for (n = 0; n < names->len; n += len, range += 2) { - char *name; - - len = strlen(names->prop + n) + 1; - name = strdup(names->prop + n); - - region = new_region(name, - dt_get_number(range, 2), - dt_get_number(range + 1, 2), - NULL, REGION_HW_RESERVED); - list_add(®ions, ®ion->list); - } - } else if (names || ranges) { - prerror("Invalid properties: reserved-names=%p " - "with reserved-ranges=%p\n", - names, ranges); - abort(); - } + mem_region_parse_reserved_properties(); unlock(&mem_region_lock); - /* We generate the reservation properties from our own region list, - * which now includes the existing data. - */ - if (names) - dt_del_property(dt_root, (struct dt_property *)names); - if (ranges) - dt_del_property(dt_root, (struct dt_property *)ranges); } static uint64_t allocated_length(const struct mem_region *r)