diff mbox

fix extract-gcov compilation when using a build directory

Message ID 1432044344-21250-1-git-send-email-clg@fr.ibm.com
State Accepted
Headers show

Commit Message

Cédric Le Goater May 19, 2015, 2:05 p.m. UTC 
Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
---
 Makefile.main |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith May 19, 2015, 9:56 p.m. UTC | #1 
Cédric Le Goater <clg@fr.ibm.com> writes:
> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
> ---
>  Makefile.main |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: skiboot.git/Makefile.main
> ===================================================================
> --- skiboot.git.orig/Makefile.main
> +++ skiboot.git/Makefile.main
> @@ -172,7 +172,7 @@ version.c: $(SRC)/make_version.sh $(OBJS
>  include $(shell find $(SRC)/* -name Makefile.check)
>
>  extract-gcov: extract-gcov.c
> -	$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) -O0 -g -I . -o $@ $<,$<)
> +	$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) -O0 -g -I$(SRC) -o $@ $<,$<)
>
>  coverage-report: skiboot.info
>  	genhtml -q -o $@ $<

Thanks, applied!

(In other news, you're probably the only one using a build directory.. I
should probably add a test somewhere for that)
Cédric Le Goater May 20, 2015, 6:15 a.m. UTC | #2 
On 05/19/2015 11:56 PM, Stewart Smith wrote:
> Cédric Le Goater <clg@fr.ibm.com> writes:
>> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
>> ---
>>  Makefile.main |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: skiboot.git/Makefile.main
>> ===================================================================
>> --- skiboot.git.orig/Makefile.main
>> +++ skiboot.git/Makefile.main
>> @@ -172,7 +172,7 @@ version.c: $(SRC)/make_version.sh $(OBJS
>>  include $(shell find $(SRC)/* -name Makefile.check)
>>
>>  extract-gcov: extract-gcov.c
>> -	$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) -O0 -g -I . -o $@ $<,$<)
>> +	$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) -O0 -g -I$(SRC) -o $@ $<,$<)
>>
>>  coverage-report: skiboot.info
>>  	genhtml -q -o $@ $<
> 
> Thanks, applied!
> 
> (In other news, you're probably the only one using a build directory.. I 
> should probably add a test somewhere for that)

I will do that. 

C.
diff mbox

Patch

Index: skiboot.git/Makefile.main
===================================================================
--- skiboot.git.orig/Makefile.main
+++ skiboot.git/Makefile.main
@@ -172,7 +172,7 @@  version.c: $(SRC)/make_version.sh $(OBJS
 include $(shell find $(SRC)/* -name Makefile.check)
 
 extract-gcov: extract-gcov.c
-	$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) -O0 -g -I . -o $@ $<,$<)
+	$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) -O0 -g -I$(SRC) -o $@ $<,$<)
 
 coverage-report: skiboot.info
 	genhtml -q -o $@ $<