| Message ID | 1426757313-20981-4-git-send-email-maddy@linux.vnet.ibm.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 03/19/2015 02:58 PM, Madhavan Srinivasan wrote: > Patch adds a new OPAL call for enabling/disabling PORE > Thread Scheduler (PTS) engine. PTS schedules different PORE > Engine threads such as PORE_SLW_IMA and so on. > > Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> > --- > include/opal.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/opal.h b/include/opal.h > index 3b31838..211002a 100644 > --- a/include/opal.h > +++ b/include/opal.h > @@ -165,7 +165,8 @@ > #define OPAL_FLASH_WRITE 111 > #define OPAL_FLASH_ERASE 112 > #define OPAL_PRD_MSG 113 > -#define OPAL_LAST 113 > +#define OPAL_UNCORE_CONTROL 114 > +#define OPAL_LAST 114 I have used token 114 and 115 for LED interface and its in upstream now ! -Vasant
On Fri, 2015-03-20 at 11:53 +0530, Vasant Hegde wrote: > On 03/19/2015 02:58 PM, Madhavan Srinivasan wrote: > > Patch adds a new OPAL call for enabling/disabling PORE > > Thread Scheduler (PTS) engine. PTS schedules different PORE > > Engine threads such as PORE_SLW_IMA and so on. > > > > Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> > > --- > > include/opal.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/opal.h b/include/opal.h > > index 3b31838..211002a 100644 > > --- a/include/opal.h > > +++ b/include/opal.h > > @@ -165,7 +165,8 @@ > > #define OPAL_FLASH_WRITE 111 > > #define OPAL_FLASH_ERASE 112 > > #define OPAL_PRD_MSG 113 > > -#define OPAL_LAST 113 > > +#define OPAL_UNCORE_CONTROL 114 > > +#define OPAL_LAST 114 > > I have used token 114 and 115 for LED interface and its in upstream now ! That's a non-issue, we fixup the token conflicts when we apply the patches, at least that's how I did, the important thing is to not merge the linux side until the token is "fixed" on the OPAL side (by merging the corresponding patch in OPAL). > -Vasant > > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
On Friday 20 March 2015 12:43 PM, Benjamin Herrenschmidt wrote: > On Fri, 2015-03-20 at 11:53 +0530, Vasant Hegde wrote: >> On 03/19/2015 02:58 PM, Madhavan Srinivasan wrote: >>> Patch adds a new OPAL call for enabling/disabling PORE >>> Thread Scheduler (PTS) engine. PTS schedules different PORE >>> Engine threads such as PORE_SLW_IMA and so on. >>> >>> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> >>> --- >>> include/opal.h | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/opal.h b/include/opal.h >>> index 3b31838..211002a 100644 >>> --- a/include/opal.h >>> +++ b/include/opal.h >>> @@ -165,7 +165,8 @@ >>> #define OPAL_FLASH_WRITE 111 >>> #define OPAL_FLASH_ERASE 112 >>> #define OPAL_PRD_MSG 113 >>> -#define OPAL_LAST 113 >>> +#define OPAL_UNCORE_CONTROL 114 >>> +#define OPAL_LAST 114 >> I have used token 114 and 115 for LED interface and its in upstream now ! > That's a non-issue, we fixup the token conflicts when we apply the > patches, at least that's how I did, the important thing is to not > merge the linux side until the token is "fixed" on the OPAL side (by > merging the corresponding patch in OPAL). Sure. Also in the next version will change the token numbers. Maddy > >> -Vasant >> >> >> _______________________________________________ >> Skiboot mailing list >> Skiboot@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/skiboot >
diff --git a/include/opal.h b/include/opal.h index 3b31838..211002a 100644 --- a/include/opal.h +++ b/include/opal.h @@ -165,7 +165,8 @@ #define OPAL_FLASH_WRITE 111 #define OPAL_FLASH_ERASE 112 #define OPAL_PRD_MSG 113 -#define OPAL_LAST 113 +#define OPAL_UNCORE_CONTROL 114 +#define OPAL_LAST 114 /* Device tree flags */
Patch adds a new OPAL call for enabling/disabling PORE Thread Scheduler (PTS) engine. PTS schedules different PORE Engine threads such as PORE_SLW_IMA and so on. Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> --- include/opal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)