mbox series

[v2,0/2] Report ec revision for p10

Message ID 20220517084622.320667-1-joel@jms.id.au
Headers show
Series Report ec revision for p10 | expand

Message

Joel Stanley May 17, 2022, 8:46 a.m. UTC 
This adds support for the ec revision (the final digit in the DD number)
for p10 CPUs.

v2 addresses review from Dan.

Joel Stanley (2):
  xscom: Move p9 ec level parsing to a function
  xscom: Parse P10 ec revision

 hw/xscom.c | 75 ++++++++++++++++++++++++++++++++----------------------
 1 file changed, 45 insertions(+), 30 deletions(-)

Comments

Dan Horák May 18, 2022, 7:48 a.m. UTC | #1 
On Tue, 17 May 2022 18:16:20 +0930
Joel Stanley <joel@jms.id.au> wrote:

> This adds support for the ec revision (the final digit in the DD number)
> for p10 CPUs.
> 
> v2 addresses review from Dan.

thanks, Joel, no more comments from me

Reviewed-by: Dan Horák <dan@danny.cz>


		Dan
 
> Joel Stanley (2):
>   xscom: Move p9 ec level parsing to a function
>   xscom: Parse P10 ec revision
> 
>  hw/xscom.c | 75 ++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 45 insertions(+), 30 deletions(-)
> 
> -- 
> 2.35.1
>
Reza Arbab May 24, 2022, 5:22 p.m. UTC | #2 
On Tue, May 17, 2022 at 06:16:20PM +0930, Joel Stanley wrote:
>This adds support for the ec revision (the final digit in the DD number)
>for p10 CPUs.

Applied to master. I took the liberty of popping an extra space in here:

   prlog(PR_INFO,"P%d DD%i.%i%d detected\n",
		^