mbox series

[0/4] better asserts

Message ID 20190925010136.7371-1-npiggin@gmail.com
Headers show
Series better asserts | expand

Message

Nicholas Piggin Sept. 25, 2019, 1:01 a.m. UTC 
This makes debugging boot failures nicer.

Thanks,
Nick

Nicholas Piggin (4):
  core/exceptions.c: rearrange code to allow more interrupt types
  trap based assertions
  branch-to-NULL assert for ELFv2 ABI
  core/exceptions.c: do not include handler code in exception backtrace

 asm/head.S            |  2 ++
 core/exceptions.c     | 56 ++++++++++++++++++++++++++++++++++++-------
 core/fast-reboot.c    |  1 +
 core/init.c           | 50 ++++++++++++++++++++++++++++++++------
 core/platform.c       |  6 ++++-
 core/stack.c          | 30 +++++++++++++++++++----
 core/utils.c          | 19 ++++-----------
 include/processor.h   |  3 +++
 include/skiboot.h     |  3 +++
 include/stack.h       |  3 +++
 libc/include/assert.h | 44 +++++++++++++++++++++++++++-------
 libc/include/stdlib.h |  7 +-----
 skiboot.lds.S         |  7 ++++++
 13 files changed, 181 insertions(+), 50 deletions(-)

Comments

Oliver O'Halloran Oct. 3, 2019, 3:10 a.m. UTC | #1 
On Wed, Sep 25, 2019 at 11:03 AM Nicholas Piggin <npiggin@gmail.com> wrote:
>
> This makes debugging boot failures nicer.

Series merged as of b70e8afdb09f56e3c7db643862cd3d2fd15a4544 with two
minor fixes:

1. The declarations of __trap_table_{start|end} were moved into
assert.h. Having them in skiboot.h broke make check since the tests
will include the system's assert.h which doesn't define struct
trap_table_entry.
2. I re-added the FWTS annotation as FailedAssert2 since the output changed.