mbox series

[0/6] scan build fixes

Message ID 20180517233105.8243-1-bsingharora@gmail.com
Headers show
Series scan build fixes | expand

Message

Balbir Singh May 17, 2018, 11:30 p.m. UTC 
I've not had a chance to test them, just compiled them,
so it's a fun patch series for the maintainer. The real issue
is exercising the various paths fixed all in one shot.

Balbir singh (6):
  Fix strtok for previous tokens being NULL
  check for NULL input string in is_sai_loc_code
  mbox/flash: Remove dead code
  p9/stop_api: Remove unnecessary stores
  libflash/blocklevel_write: Fix missing error handling
  libflash/blocklevel.c: Remove unused store to ecc_len

 hw/fsp/fsp-leds.c     |  7 +++++--
 libc/string/strtok.c  |  5 ++++-
 libflash/blocklevel.c |  4 +++-
 libflash/mbox-flash.c |  3 ---
 libpore/p9_stop_api.C | 11 +++++------
 5 files changed, 17 insertions(+), 13 deletions(-)

Comments

Stewart Smith May 25, 2018, 12:19 a.m. UTC | #1 
Balbir singh <bsingharora@gmail.com> writes:
> I've not had a chance to test them, just compiled them,
> so it's a fun patch series for the maintainer. The real issue
> is exercising the various paths fixed all in one shot.
>
> Balbir singh (6):
>   Fix strtok for previous tokens being NULL
>   check for NULL input string in is_sai_loc_code
>   mbox/flash: Remove dead code
>   p9/stop_api: Remove unnecessary stores
>   libflash/blocklevel_write: Fix missing error handling
>   libflash/blocklevel.c: Remove unused store to ecc_len

I've taken all but patch 4 as of
5802477a821e754456214bc960f9d1342fb50f9e as I want to funnel the
stop_api changes through hostboot/ekb or whatever so we get things
reviewed there.