mbox series

[v2,00/15] opal/hmi: Rework HMI handling.

Message ID 152389987405.2566.355149283827806637.stgit@jupiter.in.ibm.com
Headers show
Series opal/hmi: Rework HMI handling. | expand

Message

Mahesh J Salgaonkar April 16, 2018, 5:32 p.m. UTC 
This patch series reworks the HMI handling and introduces new opal call
for hmi handling that returns info about which timer facilities were
fixed/lost e.g. TB re-synced, HDEC lost etc..

Patch 1 and 2 are minor improvements.
Patch 3 introduces new opal call opal_handle_hmi2
Patch 4 and 5 are again minor improvements and code movement.
Patch 6 does the major code rework and introduces 4 rendez vous points where
all threads synchronizes before clearing dirty data or errors at each step.
Patch 7 to 14 are incremental improvement patches that handles specific
cases for different set of HMIs.
Patch 15 documents the opal_handle_hmi2 call.

Changes in v2:
- Rebase with upstream skiboot
- Address Stewart's comments on patch 6.
- Add documentation under doc/opal-api for opal_handle_hmi2 call.

---

Benjamin Herrenschmidt (6):
      opal/hmi: Don't re-read HMER multiple times
      opal/hmi: Remove races in clearing HMER
      opal/hmi: Add a new opal_handle_hmi2 that returns direct info to Linux
      opal/hmi: Move timer related error handling to a separate function
      opal/hmi: Don't bother passing HMER to pre-recovery cleanup
      opal/hmi: Rework HMI handling of TFAC errors

Mahesh Salgaonkar (9):
      opal/hmi: Initialize the hmi event with old value of HMER.
      opal/hmi: Do not send HMI event if no errors are found.
      opal/hmi: Fix soft lockups during TOD errors
      opal/hmi: Stop flooding HMI event for TOD errors.
      opal/hmi: Fix handling of TFMR parity/corrupt error.
      opal/hmi: Print additional debug information in rendezvous.
      opal/hmi: check thread 0 tfmr to validate latched tfmr errors.
      opal/hmi: Generate hmi event for recovered HDEC parity error.
      opal/hmi: Add documentation for opal_handle_hmi2 call


 core/cpu.c                              |    2 
 core/hmi.c                              |  714 ++++++++++++++++---------------
 doc/opal-api/opal-handle-hmi-98-166.rst |  126 +++++
 hw/chiptod.c                            |  138 +++---
 include/chiptod.h                       |    7 
 include/cpu.h                           |    3 
 include/opal-api.h                      |    8 
 include/opal-internal.h                 |    1 
 include/xscom-p9-regs.h                 |    8 
 9 files changed, 578 insertions(+), 429 deletions(-)
 create mode 100644 doc/opal-api/opal-handle-hmi-98-166.rst

--
Signature

Comments

Stewart Smith April 19, 2018, 6:01 a.m. UTC | #1 
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> writes:
> This patch series reworks the HMI handling and introduces new opal call
> for hmi handling that returns info about which timer facilities were
> fixed/lost e.g. TB re-synced, HDEC lost etc..
>
> Patch 1 and 2 are minor improvements.
> Patch 3 introduces new opal call opal_handle_hmi2
> Patch 4 and 5 are again minor improvements and code movement.
> Patch 6 does the major code rework and introduces 4 rendez vous points where
> all threads synchronizes before clearing dirty data or errors at each step.
> Patch 7 to 14 are incremental improvement patches that handles specific
> cases for different set of HMIs.
> Patch 15 documents the opal_handle_hmi2 call.
>
> Changes in v2:
> - Rebase with upstream skiboot
> - Address Stewart's comments on patch 6.
> - Add documentation under doc/opal-api for opal_handle_hmi2 call.

Thanks! Especially thanks for the documentation, it's probably some of
the most complete documentation we have now!

Series merged to master as of c4fd54bf413e74146e74ed173b358b88f25ece3d