mbox series

[0/6] opal/hmi: Improve HMI log messages

Message ID 151297009432.31824.10846644245746807018.stgit@jupiter.in.ibm.com
Headers show
Series opal/hmi: Improve HMI log messages | expand

Message

Mahesh J Salgaonkar Dec. 11, 2017, 5:30 a.m. UTC
This patch series adds few additional opal log messages that displays
location code information of a processor chip where errors were reported.
It also displays chip, core and thread id information.

With this patch series the HMI log messages will look like:

[210612.175196744,7] HMI: Received HMI interrupt: HMER = 0x0840000000000000
[210612.175200449,7] HMI: [Loc: UOPWR.1302LFA-Node0-Proc1]: P:8 C:16 T:1: TFMR(2d12000870e04020) Timer Facility Error

[210660.259689526,7] HMI: Received HMI interrupt: HMER = 0x2040000000000000
[210660.259695649,7] HMI: [Loc: UOPWR.1302LFA-Node0-Proc0]: P:0 C:16 T:1: Processor recovery Done.

---

Mahesh Salgaonkar (5):
      opal: Get chip location code
      core/hmi: Use pr_fmt macro for tagging log messages
      opal/hmi: HMI logging with location code info.
      core/hmi: Do not display FIR details if none of the bits are set.
      core/hmi: Display chip location code while displaying core FIR.

Vasant Hegde (1):
      hdata: Add location code property to xscom node


 core/chip.c    |   10 +++++++
 core/hmi.c     |   75 +++++++++++++++++++++++++++++++++++++++++++-------------
 hdata/spira.c  |    5 ++++
 include/chip.h |   15 +++++++++++
 4 files changed, 88 insertions(+), 17 deletions(-)

--
Signature

Comments

Stewart Smith Dec. 12, 2017, 10:47 p.m. UTC | #1
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> writes:
> This patch series adds few additional opal log messages that displays
> location code information of a processor chip where errors were reported.
> It also displays chip, core and thread id information.
>
> With this patch series the HMI log messages will look like:
>
> [210612.175196744,7] HMI: Received HMI interrupt: HMER = 0x0840000000000000
> [210612.175200449,7] HMI: [Loc: UOPWR.1302LFA-Node0-Proc1]: P:8 C:16 T:1: TFMR(2d12000870e04020) Timer Facility Error
>
> [210660.259689526,7] HMI: Received HMI interrupt: HMER = 0x2040000000000000
> [210660.259695649,7] HMI: [Loc: UOPWR.1302LFA-Node0-Proc0]: P:0 C:16
> T:1: Processor recovery Done.

That looks like an improvement!

As Vasant mentioned ,if these break the hdat tests then that needs to
be fixed before merging.
Mahesh J Salgaonkar Dec. 13, 2017, 5 a.m. UTC | #2
On 12/13/2017 04:17 AM, Stewart Smith wrote:
> Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> writes:
>> This patch series adds few additional opal log messages that displays
>> location code information of a processor chip where errors were reported.
>> It also displays chip, core and thread id information.
>>
>> With this patch series the HMI log messages will look like:
>>
>> [210612.175196744,7] HMI: Received HMI interrupt: HMER = 0x0840000000000000
>> [210612.175200449,7] HMI: [Loc: UOPWR.1302LFA-Node0-Proc1]: P:8 C:16 T:1: TFMR(2d12000870e04020) Timer Facility Error
>>
>> [210660.259689526,7] HMI: Received HMI interrupt: HMER = 0x2040000000000000
>> [210660.259695649,7] HMI: [Loc: UOPWR.1302LFA-Node0-Proc0]: P:0 C:16
>> T:1: Processor recovery Done.
> 
> That looks like an improvement!
> 
> As Vasant mentioned ,if these break the hdat tests then that needs to
> be fixed before merging.
> 

Yup, Will send out v2.

Thanks,
-Mahesh.