From patchwork Wed Nov 18 08:30:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 38734 Return-Path: <3nrADSwcJCZ0BOOLOZeDJ7FI.9LJOQ9-IFKRUDLLDIBDOLRMP.9LJ@groups.bounces.google.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yx0-f158.google.com (mail-yx0-f158.google.com [209.85.210.158]) by ozlabs.org (Postfix) with ESMTP id 3ED68B6EE8 for ; Wed, 18 Nov 2009 19:30:28 +1100 (EST) Received: by yxe30 with SMTP id 30sf1324429yxe.29 for ; Wed, 18 Nov 2009 00:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:date:from :x-x-sender:to:cc:subject:message-id:user-agent:mime-version :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:x-thread-url:x-message-url:content-type; bh=SfdCwg8X5BUPWPYFaJ2eooiVspVDqpIr1kF4hjhqinM=; b=Swn/RSzAKn/qJ+IKafM5p8cPYNMkhem7PgOZlMdzlEcl8aqz/uF3mZqt2rMKyRxppc 7484f72oW4vZuqPVY+plVDlQ5Xt1rtMldULkBnoxeoe8bXvRx/K3PN0XHn5c6tnes3CE D/6dzCnRfxST+kkkOUDSuIZPqCJ9EbGWpZUjE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=x-beenthere:received-spf:authentication-results:date:from :x-x-sender:to:cc:subject:message-id:user-agent:mime-version :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:x-thread-url:x-message-url:content-type; b=kC6OQUigMEJQM9/mynQgtw4PcctnaYX6GnYU5aB8dEQPaft7/fgN1bNnpHKXXjQGAN cqaBM73xkhkMF8Sm6m60e+aMzWnv9beywI1VZ9GR9ABhlmg+vrbiXVajPEFRRZIZRflE LIQepuHRZW+5rw6teyg+n8mTNUjYloUL58iZs= Received: by 10.91.163.7 with SMTP id q7mr158181ago.28.1258533022933; Wed, 18 Nov 2009 00:30:22 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.86.239.10 with SMTP id m10ls453677fgh.0.p; Wed, 18 Nov 2009 00:30:21 -0800 (PST) Received: by 10.86.13.38 with SMTP id 38mr33068fgm.26.1258533021655; Wed, 18 Nov 2009 00:30:21 -0800 (PST) Received: by 10.86.13.38 with SMTP id 38mr33067fgm.26.1258533021627; Wed, 18 Nov 2009 00:30:21 -0800 (PST) Received: from ey-out-1920.google.com (ey-out-1920.google.com [74.125.78.145]) by gmr-mx.google.com with ESMTP id 11si828751fxm.6.2009.11.18.00.30.20; Wed, 18 Nov 2009 00:30:20 -0800 (PST) Received-SPF: pass (google.com: domain of error27@gmail.com designates 74.125.78.145 as permitted sender) client-ip=74.125.78.145; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of error27@gmail.com designates 74.125.78.145 as permitted sender) smtp.mail=error27@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by ey-out-1920.google.com with SMTP id 26so78164eyw.54 for ; Wed, 18 Nov 2009 00:30:20 -0800 (PST) Received: by 10.213.96.195 with SMTP id i3mr48766ebn.97.1258533020486; Wed, 18 Nov 2009 00:30:20 -0800 (PST) Received: from bicker.local ([41.222.20.196]) by mx.google.com with ESMTPS id 10sm1138235eyd.31.2009.11.18.00.30.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 18 Nov 2009 00:30:19 -0800 (PST) Date: Wed, 18 Nov 2009 10:30:14 +0200 (SAST) From: Dan Carpenter X-X-Sender: dcarpenter@bicker To: balajirrao@openmoko.org cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [patch] rtc: use after free in pcf50633_rtc_probe() Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rtc-linux/t/fe0373baa0572a86 X-Message-Url: http://groups.google.com/group/rtc-linux/msg/9d2df3831421e390 "rtc" is freed and then dereferenced on the next line. This patch fixes that. This is a resend. I have been offline for the last few months so I may have missed a reply or something. Not sure what the status was. regards, dan carpenter Signed-off-by: Dan Carpenter --- orig/drivers/rtc/rtc-pcf50633.c 2009-07-17 16:21:52.000000000 +0300 +++ new/drivers/rtc/rtc-pcf50633.c 2009-07-17 16:22:56.000000000 +0300 @@ -291,8 +291,9 @@ &pcf50633_rtc_ops, THIS_MODULE); if (IS_ERR(rtc->rtc_dev)) { + int ret = PTR_ERR(rtc->rtc_dev); kfree(rtc); - return PTR_ERR(rtc->rtc_dev); + return ret; } pcf50633_register_irq(rtc->pcf, PCF50633_IRQ_ALARM,