diff mbox series

rtc: r7301: Use devm_platform_ioremap_resource() in rtc7301_rtc_probe()

Message ID 8c17a59c-82ff-aa6b-5653-a38d786d3e83@web.de
State Accepted
Headers show
Series rtc: r7301: Use devm_platform_ioremap_resource() in rtc7301_rtc_probe() | expand

Commit Message

Markus Elfring Sept. 21, 2019, 11:49 a.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 21 Sep 2019 13:43:07 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/rtc/rtc-r7301.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

--
2.23.0

Comments

Akinobu Mita Sept. 22, 2019, 2:46 a.m. UTC | #1 
2019年9月21日(土) 20:49 Markus Elfring <Markus.Elfring@web.de>:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 21 Sep 2019 13:43:07 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-r7301.c b/drivers/rtc/rtc-r7301.c
index 2498278853af..aaf1b95e3990 100644
--- a/drivers/rtc/rtc-r7301.c
+++ b/drivers/rtc/rtc-r7301.c
@@ -354,21 +354,16 @@  static void rtc7301_init(struct rtc7301_priv *priv)

 static int __init rtc7301_rtc_probe(struct platform_device *dev)
 {
-	struct resource *res;
 	void __iomem *regs;
 	struct rtc7301_priv *priv;
 	struct rtc_device *rtc;
 	int ret;

-	res = platform_get_resource(dev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
-
 	priv = devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;

-	regs = devm_ioremap_resource(&dev->dev, res);
+	regs = devm_platform_ioremap_resource(dev, 0);
 	if (IS_ERR(regs))
 		return PTR_ERR(regs);