From patchwork Tue Mar 3 05:49:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joshua Kinard X-Patchwork-Id: 445552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yk0-x23f.google.com (mail-yk0-x23f.google.com [IPv6:2607:f8b0:4002:c07::23f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2A15214010F for ; Tue, 3 Mar 2015 16:49:30 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="2048-bit key; unprotected key" header.d=googlegroups.com header.i=@googlegroups.com header.b=oOl4oTN+; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: by ykbq200 with SMTP id q200sf9042189ykb.0 for ; Mon, 02 Mar 2015 21:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe; bh=udGX05wzSEM8BE5RD93O4ZEjVbt79lP+RJYAwAwMMN8=; b=oOl4oTN+lia8js+hDnzQfIBWS/5Uak556vI/fRM600EY0a3gvM9+07G7hnZtN11+zB 5yM/YB3ZU4LD6/5FmfNVvam1IqyAV6EDCQvDdaDo/TrOulnDGnViOoy626gtFwc3EmVg OLa6PRX8YRGdM2S01wnh9b8We9ADXsJzFOzx1X0LBSjcYWqlqol8mqlZy05UXuAC/ctf 92RgXN7EwxGOS/2Rg9JCoMeSGKqjtkkuJLFvB1qYE0UkTUruXgXvVBF7g2KqgZ8godzb tsy9FKDREVJDYw0DOrE+qHpL670KRbyTUa4FOLfdBEzxWtsHN9+92JxChyUhNfUo51TW MwWw== X-Received: by 10.182.191.36 with SMTP id gv4mr209066obc.37.1425361767982; Mon, 02 Mar 2015 21:49:27 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.182.107.199 with SMTP id he7ls808453obb.76.gmail; Mon, 02 Mar 2015 21:49:27 -0800 (PST) X-Received: by 10.182.98.230 with SMTP id el6mr11244970obb.49.1425361767646; Mon, 02 Mar 2015 21:49:27 -0800 (PST) Received: from resqmta-ch2-07v.sys.comcast.net (resqmta-ch2-07v.sys.comcast.net. [2001:558:fe21:29:69:252:207:39]) by gmr-mx.google.com with ESMTPS id e5si2105020qcg.1.2015.03.02.21.49.27 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Mar 2015 21:49:27 -0800 (PST) Received-SPF: neutral (google.com: 2001:558:fe21:29:69:252:207:39 is neither permitted nor denied by domain of kumba@gentoo.org) client-ip=2001:558:fe21:29:69:252:207:39; Received: from resomta-ch2-08v.sys.comcast.net ([69.252.207.104]) by resqmta-ch2-07v.sys.comcast.net with comcast id ytpT1p0022Fh1PH01tpT90; Tue, 03 Mar 2015 05:49:27 +0000 Received: from [192.168.1.13] ([69.250.160.75]) by resomta-ch2-08v.sys.comcast.net with comcast id ytpR1p0041duFqV01tpRad; Tue, 03 Mar 2015 05:49:27 +0000 Message-ID: <54F54B60.2080207@gentoo.org> Date: Tue, 03 Mar 2015 00:49:20 -0500 From: Joshua Kinard User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andrew Morton , Alessandro Zummo CC: rtc-linux@googlegroups.com, LKML Subject: [rtc-linux] [PATCH]: rtc: ds1685: Fix sparse warnings X-Original-Sender: kumba@gentoo.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:558:fe21:29:69:252:207:39 is neither permitted nor denied by domain of kumba@gentoo.org) smtp.mail=kumba@gentoo.org; dkim=pass header.i=@comcast.net Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Joshua Kinard Fix two minor sparse warnings: CHECK drivers/rtc/rtc-ds1685.c drivers/rtc/rtc-ds1685.c:2178:1: warning: function 'ds1685_rtc_poweroff' with external linkage has definition drivers/rtc/rtc-ds1685.c:802:23: warning: Using plain integer as NULL pointer Signed-off-by: Joshua Kinard Fixes: aaaf5fbf56f1: "rtc: add driver for DS1685 family of real time clocks" --- drivers/rtc/rtc-ds1685.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c index 7a7c8de..7020209 100644 --- a/drivers/rtc/rtc-ds1685.c +++ b/drivers/rtc/rtc-ds1685.c @@ -799,7 +799,7 @@ ds1685_rtc_proc(struct device *dev, struct seq_file *seq) struct platform_device *pdev = to_platform_device(dev); struct ds1685_priv *rtc = platform_get_drvdata(pdev); u8 ctrla, ctrlb, ctrlc, ctrld, ctrl4a, ctrl4b, ssn[8]; - char *model = '\0'; + char *model; #ifdef CONFIG_RTC_DS1685_PROC_REGS char bits[NUM_REGS][(NUM_BITS * NUM_SPACES) + NUM_BITS + 1]; #endif @@ -2174,7 +2174,7 @@ module_exit(ds1685_rtc_exit); * ds1685_rtc_poweroff - uses the RTC chip to power the system off. * @pdev: pointer to platform_device structure. */ -extern void __noreturn +void __noreturn ds1685_rtc_poweroff(struct platform_device *pdev) { u8 ctrla, ctrl4a, ctrl4b;