| Message ID | 20250513161922.4064-7-markus.burri@mt.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rtc-rv8803: Implement timestamp trigger over event pins | expand |
On Tue, 13 May 2025 18:19:21 +0200, Markus Burri wrote: > Document tamper detection property for epson,rx8901 rtc chip. > > Signed-off-by: Markus Burri <markus.burri@mt.com> > --- > .../devicetree/bindings/rtc/epson,rx8900.yaml | 40 +++++++++++++++++-- > 1 file changed, 37 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml: buffer-mode: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250513161922.4064-7-markus.burri@mt.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, May 13, 2025 at 06:19:21PM +0200, Markus Burri wrote: > Document tamper detection property for epson,rx8901 rtc chip. Looks like a lot more than 1 property. Explain the feature and why it is needed. What the change is is obvious reading the diff. > > Signed-off-by: Markus Burri <markus.burri@mt.com> > --- > .../devicetree/bindings/rtc/epson,rx8900.yaml | 40 +++++++++++++++++-- > 1 file changed, 37 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml b/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml > index 03af81754482..c2e542c9bdc6 100644 > --- a/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml > +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml > @@ -9,9 +9,6 @@ title: EPSON RX8900 / Microcrystal RV8803 Real-Time Clock > maintainers: > - Marek Vasut <marex@denx.de> > > -allOf: > - - $ref: rtc.yaml# > - > properties: > compatible: > enum: > @@ -33,6 +30,43 @@ properties: > > wakeup-source: true > > + tamper: > + description: Subnode for tamper configuration. This > + subnode is only available for epson,rx8901. Wrap at 80 char. > + type: object > + additionalProperties: false blank line > + properties: > + buffer-mode: > + description: Set the buffer mode to inhibit (0) or overwrite (1). > + minimum: 0 > + maximum: 1 Could be boolean? blank line > + patternProperties: > + "^evin-[0-3]$": > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 3 > + maxItems: 3 > + description: | > + Event input pin configuration. > + The configuration is an array of tree values and contains > + "pull-resistore", "trigger" and "filter". pull-resistor > + For a detaild description, see epson-rx8901 datasheet. detailed blank line between paragraphs. > + > +allOf: > + - $ref: rtc.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - epson,rx8901 > + then: > + properties: > + tamper: true Don't need this. It is allowed by default. Invert the if. > + else: > + # property is not allowed: Drop comment > + properties: > + tamper: false > + > required: > - compatible > - reg > -- > 2.39.5 >
diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml b/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml index 03af81754482..c2e542c9bdc6 100644 --- a/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml @@ -9,9 +9,6 @@ title: EPSON RX8900 / Microcrystal RV8803 Real-Time Clock maintainers: - Marek Vasut <marex@denx.de> -allOf: - - $ref: rtc.yaml# - properties: compatible: enum: @@ -33,6 +30,43 @@ properties: wakeup-source: true + tamper: + description: Subnode for tamper configuration. This + subnode is only available for epson,rx8901. + type: object + additionalProperties: false + properties: + buffer-mode: + description: Set the buffer mode to inhibit (0) or overwrite (1). + minimum: 0 + maximum: 1 + patternProperties: + "^evin-[0-3]$": + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 3 + maxItems: 3 + description: | + Event input pin configuration. + The configuration is an array of tree values and contains + "pull-resistore", "trigger" and "filter". + For a detaild description, see epson-rx8901 datasheet. + +allOf: + - $ref: rtc.yaml# + - if: + properties: + compatible: + contains: + enum: + - epson,rx8901 + then: + properties: + tamper: true + else: + # property is not allowed: + properties: + tamper: false + required: - compatible - reg
Document tamper detection property for epson,rx8901 rtc chip. Signed-off-by: Markus Burri <markus.burri@mt.com> --- .../devicetree/bindings/rtc/epson,rx8900.yaml | 40 +++++++++++++++++-- 1 file changed, 37 insertions(+), 3 deletions(-)