diff mbox series

[v3,1/2] dt-bindings: rtc: Add pcf85053a support

Message ID 20250507072618.153960-1-pankit.garg@nxp.com
State New
Headers show
Series [v3,1/2] dt-bindings: rtc: Add pcf85053a support | expand

Commit Message

Pankit Garg May 7, 2025, 7:26 a.m. UTC
Add device tree bindings for NXP PCF85053a RTC chip.

Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
---
V2 -> V3: Moved MAINTAINERS file changes to the driver patch
V1 -> V2: Handled dt-bindings by trivial-rtc.yaml

---
 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley May 7, 2025, 2:22 p.m. UTC | #1
On Wed, May 07, 2025 at 12:56:17PM +0530, Pankit Garg wrote:
> Add device tree bindings for NXP PCF85053a RTC chip.
> 
> Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> ---
> V2 -> V3: Moved MAINTAINERS file changes to the driver patch
> V1 -> V2: Handled dt-bindings by trivial-rtc.yaml

You forgot to add my ack.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> 
> ---
>  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> index 7330a7200831..47be7bbbfedd 100644
> --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> @@ -65,6 +65,8 @@ properties:
>        - microcrystal,rv8523
>        # NXP LPC32xx SoC Real-time Clock
>        - nxp,lpc3220-rtc
> +      # NXP PCF85053A Real Time Clock Module with I2C-Bus
> +      - nxp,pcf85053a
>        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
>        - ricoh,r2025sd
>        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> -- 
> 2.25.1
>
Pankit Garg May 8, 2025, 5:21 a.m. UTC | #2
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Wednesday, May 7, 2025 7:53 PM
> To: Pankit Garg <pankit.garg@nxp.com>
> Cc: linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; conor+dt@kernel.org; robh@kernel.org;
> alexandre.belloni@bootlin.com; Vikash Bansal <vikash.bansal@nxp.com>;
> Priyanka Jain <priyanka.jain@nxp.com>; Daniel Aguirre
> <daniel.aguirre@nxp.com>; Shashank Rebbapragada
> <shashank.rebbapragada@nxp.com>; Aman Kumar Pandey
> <aman.kumarpandey@nxp.com>
> Subject: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support
> 
> On Wed, May 07, 2025 at 12:56:17PM +0530, Pankit Garg wrote:
> > Add device tree bindings for NXP PCF85053a RTC chip.
> >
> > Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> > ---
> > V2 -> V3: Moved MAINTAINERS file changes to the driver patch
> > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
> 
> You forgot to add my ack.
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Yes, I forgot. I will add it in v4. Let me wait for more review/comments for couple of days.

> 
> >
> > ---
> >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > index 7330a7200831..47be7bbbfedd 100644
> > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > @@ -65,6 +65,8 @@ properties:
> >        - microcrystal,rv8523
> >        # NXP LPC32xx SoC Real-time Clock
> >        - nxp,lpc3220-rtc
> > +      # NXP PCF85053A Real Time Clock Module with I2C-Bus
> > +      - nxp,pcf85053a
> >        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> >        - ricoh,r2025sd
> >        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> > --
> > 2.25.1
> >
liudalin@kylinos.com.cn May 8, 2025, 6:38 a.m. UTC | #3
Hi Binbin:



   The described issue does not happened  with or without the patch by test, as the interrupt is managed by acpi. 



The device info and test result are as follows.



1. Device info

[系统未激活][root@mail test]# dmidecode -q
BIOS Information
        Vendor: ZD-TECH
        Version: V09
        Release Date: 06/15/2022
        ROM Size: 8 MB
        Characteristics:
                PCI is supported
                BIOS is upgradeable
                BIOS shadowing is allowed
                Boot from CD is supported
                Selectable boot is supported
                BIOS ROM is socketed
                Serial services are supported (int 14h)
                USB legacy is supported
                Function key-initiated network boot is supported
                UEFI is supported
        BIOS Revision: 4.0
        Firmware Revision: 0.4

System Information
        Manufacturer: GEIT
        Product Name: UT6000-LB5
        Version: 1.0
        Serial Number: TBD by OEM
        UUID: 00112233-4455-6677-8899-aabbccddeeff
        Wake-up Type: Power Switch
        SKU Number: Loongson_SKU
        Family: Type1Family

Base Board Information
        Manufacturer: GEIT
        Product Name: GG-3A5000-02
        Version: 1.0
        Serial Number: Chassis Board Serial#To Be Filled By O.E.M
        Asset Tag: Type2 - Board Asset Tag
        Features:
                Board is a hosting board
                Board is replaceable
        Location In Chassis: Type2 - Board Chassis Location
        Type: Motherboard

...


2. The system exhibits a timeout error when waiting for alarm signal response without the patch.

[系统未激活][root@mail test]# cat /proc/interrupts |grep acpi
 21:          3          0          0          0   PCH PIC   1  acpi
[系统未激活][root@mail test]#
[系统未激活][root@mail test]# ./rtc01
RTC READ TEST:
RTC READ TEST Passed
Current RTC date/time is 8-5-2025, 05:50:05.
RTC ALARM TEST :Alarm time set to 05:50:10.
Waiting 5 seconds for the alarm...
Timed out waiting for the alarm
RTC UPDATE INTERRUPTS TEST :
RTC_UIE_ON not supported
RTC Tests Done!
[系统未激活][root@mail test]#
[系统未激活][root@mail test]# cat /proc/interrupts |grep acpi
 21:          4          0          0          0   PCH PIC   1  acpi
[系统未激活][root@mail test]#




3. There is no error with the patch applied and the interrupts are triggered ok
[系统未激活][root@mail test]# cat /proc/interrupts |grep acpi
 21:          0          0          0          0   PCH PIC   1  acpi
[系统未激活][root@mail test]#
[系统未激活][root@mail test]# ./rtc01
RTC READ TEST:
RTC READ TEST Passed
Current RTC date/time is 8-5-2025, 06:09:03.
RTC ALARM TEST :Alarm time set to 06:09:08.
Waiting 5 seconds for the alarm...
Alarm rang.
RTC ALARM TEST Passed
RTC UPDATE INTERRUPTS TEST :
RTC_UIE_ON not supported
RTC Tests Done!
[系统未激活][root@mail test]#
[系统未激活][root@mail test]# cat /proc/interrupts |grep acpi
 21:          1          0          0          0   PCH PIC   1  acpi
[系统未激活][root@mail test]#






From: Pankit Garg



Date: 2025-05-08 13:21



To: Conor Dooley



CC: linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; conor+dt@kernel.org; robh@kernel.org; alexandre.belloni@bootlin.com; Vikash Bansal; Priyanka Jain; Daniel Aguirre; Shashank Rebbapragada; Aman Kumar Pandey



Subject: RE: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support



 



 



> -----Original Message-----



> From: Conor Dooley <conor@kernel.org>



> Sent: Wednesday, May 7, 2025 7:53 PM



> To: Pankit Garg <pankit.garg@nxp.com>



> Cc: linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; linux-



> kernel@vger.kernel.org; conor+dt@kernel.org; robh@kernel.org;



> alexandre.belloni@bootlin.com; Vikash Bansal <vikash.bansal@nxp.com>;



> Priyanka Jain <priyanka.jain@nxp.com>; Daniel Aguirre



> <daniel.aguirre@nxp.com>; Shashank Rebbapragada



> <shashank.rebbapragada@nxp.com>; Aman Kumar Pandey



> <aman.kumarpandey@nxp.com>



> Subject: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support



>



> On Wed, May 07, 2025 at 12:56:17PM +0530, Pankit Garg wrote:



> > Add device tree bindings for NXP PCF85053a RTC chip.



> >



> > Signed-off-by: Pankit Garg <pankit.garg@nxp.com>



> > ---



> > V2 -> V3: Moved MAINTAINERS file changes to the driver patch



> > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml



>



> You forgot to add my ack.



> Acked-by: Conor Dooley <conor.dooley@microchip.com>



 



Yes, I forgot. I will add it in v4. Let me wait for more review/comments for couple of days.



 



>



> >



> > ---



> >  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++



> >  1 file changed, 2 insertions(+)



> >



> > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml



> b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml



> > index 7330a7200831..47be7bbbfedd 100644



> > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml



> > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml



> > @@ -65,6 +65,8 @@ properties:



> >        - microcrystal,rv8523



> >        # NXP LPC32xx SoC Real-time Clock



> >        - nxp,lpc3220-rtc



> > +      # NXP PCF85053A Real Time Clock Module with I2C-Bus



> > +      - nxp,pcf85053a



> >        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC



> >        - ricoh,r2025sd



> >        # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC



> > --



> > 2.25.1



> >
Conor Dooley May 8, 2025, 2:23 p.m. UTC | #4
On Thu, May 08, 2025 at 05:21:47AM +0000, Pankit Garg wrote:
> 
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: Wednesday, May 7, 2025 7:53 PM
> > To: Pankit Garg <pankit.garg@nxp.com>
> > Cc: linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; conor+dt@kernel.org; robh@kernel.org;
> > alexandre.belloni@bootlin.com; Vikash Bansal <vikash.bansal@nxp.com>;
> > Priyanka Jain <priyanka.jain@nxp.com>; Daniel Aguirre
> > <daniel.aguirre@nxp.com>; Shashank Rebbapragada
> > <shashank.rebbapragada@nxp.com>; Aman Kumar Pandey
> > <aman.kumarpandey@nxp.com>
> > Subject: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support
> > 
> > On Wed, May 07, 2025 at 12:56:17PM +0530, Pankit Garg wrote:
> > > Add device tree bindings for NXP PCF85053a RTC chip.
> > >
> > > Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> > > ---
> > > V2 -> V3: Moved MAINTAINERS file changes to the driver patch
> > > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
> > 
> > You forgot to add my ack.
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Yes, I forgot. I will add it in v4. Let me wait for more review/comments for couple of days.

And if you don't get comments, don't resend just for that, the
maintainer will gather the tag.
Pankit Garg June 9, 2025, 7:07 a.m. UTC | #5
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Thursday, May 8, 2025 7:54 PM
> To: Pankit Garg <pankit.garg@nxp.com>
> Cc: linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; conor+dt@kernel.org; robh@kernel.org;
> alexandre.belloni@bootlin.com; Vikash Bansal <vikash.bansal@nxp.com>;
> Priyanka Jain <priyanka.jain@nxp.com>; Daniel Aguirre
> <daniel.aguirre@nxp.com>; Shashank Rebbapragada
> <shashank.rebbapragada@nxp.com>; Aman Kumar Pandey
> <aman.kumarpandey@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support
> 
> On Thu, May 08, 2025 at 05:21:47AM +0000, Pankit Garg wrote:
> >
> >
> > > -----Original Message-----
> > > From: Conor Dooley <conor@kernel.org>
> > > Sent: Wednesday, May 7, 2025 7:53 PM
> > > To: Pankit Garg <pankit.garg@nxp.com>
> > > Cc: linux-rtc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; conor+dt@kernel.org; robh@kernel.org;
> > > alexandre.belloni@bootlin.com; Vikash Bansal
> > > <vikash.bansal@nxp.com>; Priyanka Jain <priyanka.jain@nxp.com>;
> > > Daniel Aguirre <daniel.aguirre@nxp.com>; Shashank Rebbapragada
> > > <shashank.rebbapragada@nxp.com>; Aman Kumar Pandey
> > > <aman.kumarpandey@nxp.com>
> > > Subject: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a
> > > support
> > >
> > > On Wed, May 07, 2025 at 12:56:17PM +0530, Pankit Garg wrote:
> > > > Add device tree bindings for NXP PCF85053a RTC chip.
> > > >
> > > > Signed-off-by: Pankit Garg <pankit.garg@nxp.com>
> > > > ---
> > > > V2 -> V3: Moved MAINTAINERS file changes to the driver patch
> > > > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
> > >
> > > You forgot to add my ack.
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > Yes, I forgot. I will add it in v4. Let me wait for more review/comments for
> couple of days.
> 
> And if you don't get comments, don't resend just for that, the maintainer will
> gather the tag.

Since there wasn't any feedback for this patch, i want to send a gentle
reminder ...

Regards
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
index 7330a7200831..47be7bbbfedd 100644
--- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
@@ -65,6 +65,8 @@  properties:
       - microcrystal,rv8523
       # NXP LPC32xx SoC Real-time Clock
       - nxp,lpc3220-rtc
+      # NXP PCF85053A Real Time Clock Module with I2C-Bus
+      - nxp,pcf85053a
       # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
       - ricoh,r2025sd
       # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC