| Message ID | 20250423130318.31244-7-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: drop unused module alias | expand |
On 23/04/2025 15:03, Johan Hovold wrote: > The driver only support OF probe so drop the unused platform module > alias. > > Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type") I believe this is not correct, but instead commit dropping last platform user, which I think was: Fixes: 0d297df03890 ("ARM: s3c: simplify platform code") Just like in other patches here, these are old drivers and even if they have OF matching method, they can be or they were modprobed via board files. > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- With the fixes tag fixed (to whatever commit dropping last platform user): Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote: > On 23/04/2025 15:03, Johan Hovold wrote: > > The driver only support OF probe so drop the unused platform module > > alias. > > > > Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type") > > I believe this is not correct, but instead commit dropping last platform > user, which I think was: > > Fixes: 0d297df03890 ("ARM: s3c: simplify platform code") No, as I write in the commit message, the driver only supports OF probe since the commit I refer to. It fails with -EINVAL and the following error logged: failed getting s3c_rtc_data for non-OF probe. > Just like in other patches here, these are old drivers and even if they > have OF matching method, they can be or they were modprobed via board files. See above, similar reasoning applies for the other patches. Johan
On 06/05/2025 16:35, Johan Hovold wrote: > On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote: >> On 23/04/2025 15:03, Johan Hovold wrote: >>> The driver only support OF probe so drop the unused platform module >>> alias. >>> >>> Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type") >> >> I believe this is not correct, but instead commit dropping last platform >> user, which I think was: >> >> Fixes: 0d297df03890 ("ARM: s3c: simplify platform code") > > No, as I write in the commit message, the driver only supports OF probe > since the commit I refer to. It fails with -EINVAL and the following > error logged: > > failed getting s3c_rtc_data > > for non-OF probe. Haha, nice, so commit in 2014 nicely broke that platform's RTC. There is one more thing: back in 2013-2015, I don't remember exactly, the module loading/matching was not working with OF and you needed aliases for the actual bus - platform or I2C. IIRC, the bus - platform bus in this case - trigger uevent for module and then device match would be via OF. Anyway, this would be only for s3c2410 DT platform, because all others (newer) use different compatible thus there would be no s3c2410-rtc uevent for them. Well, does not matter much, just sharing. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 58c957eb753d..5dd575865adf 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -609,4 +609,3 @@ module_platform_driver(s3c_rtc_driver); MODULE_DESCRIPTION("Samsung S3C RTC Driver"); MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:s3c2410-rtc");
The driver only support OF probe so drop the unused platform module alias. Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/rtc/rtc-s3c.c | 1 - 1 file changed, 1 deletion(-)