diff mbox series

[2/4] dt-bindings: rtc: abx80x: Convert text bindings to YAML

Message ID 20240305004222.622-3-laurent.pinchart@ideasonboard.com
State Rejected
Headers show
Series Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS | expand

Commit Message

Laurent Pinchart March 5, 2024, 12:42 a.m. UTC 
Convert the abx80x DT bindings to YAML schema. The existing properties
are kept without modification, and the interrupt property is added as it
is supported by the driver.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
If someone wants to volunteer as a maintainer, by all means, please fee
to replace me :-)
---
 .../bindings/rtc/abracon,abx80x.txt           | 31 -------
 .../bindings/rtc/abracon,abx80x.yaml          | 89 +++++++++++++++++++
 2 files changed, 89 insertions(+), 31 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml

Comments

Baruch Siach March 5, 2024, 4:46 a.m. UTC | #1 
Hi Laurent,

On Tue, Mar 05 2024, Laurent Pinchart wrote:
> Convert the abx80x DT bindings to YAML schema. The existing properties
> are kept without modification, and the interrupt property is added as it
> is supported by the driver.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Done already in rtc-next:

https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=626e2b54645a4e9b58bcb479a565b4a06ff76a26

baruch
Laurent Pinchart March 5, 2024, 7:28 a.m. UTC | #2 
On Tue, Mar 05, 2024 at 06:46:10AM +0200, Baruch Siach wrote:
> On Tue, Mar 05 2024, Laurent Pinchart wrote:
> > Convert the abx80x DT bindings to YAML schema. The existing properties
> > are kept without modification, and the interrupt property is added as it
> > is supported by the driver.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Done already in rtc-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=626e2b54645a4e9b58bcb479a565b4a06ff76a26

Great :-) Thanks for the link.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
deleted file mode 100644
index 2405e35a1bc0..000000000000
--- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
+++ /dev/null
@@ -1,31 +0,0 @@ 
-Abracon ABX80X I2C ultra low power RTC/Alarm chip
-
-The Abracon ABX80X family consist of the ab0801, ab0803, ab0804, ab0805, ab1801,
-ab1803, ab1804 and ab1805. The ab0805 is the superset of ab080x and the ab1805
-is the superset of ab180x.
-
-Required properties:
-
- - "compatible": should one of:
-        "abracon,abx80x"
-        "abracon,ab0801"
-        "abracon,ab0803"
-        "abracon,ab0804"
-        "abracon,ab0805"
-        "abracon,ab1801"
-        "abracon,ab1803"
-        "abracon,ab1804"
-        "abracon,ab1805"
-        "microcrystal,rv1805"
-	Using "abracon,abx80x" will enable chip autodetection.
- - "reg": I2C bus address of the device
-
-Optional properties:
-
-The abx804 and abx805 have a trickle charger that is able to charge the
-connected battery or supercap. Both the following properties have to be defined
-and valid to enable charging:
-
- - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
- - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
-                          resistor, the other values are in kOhm.
diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
new file mode 100644
index 000000000000..02bee3038b0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
@@ -0,0 +1,89 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/abracon,abx80x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Abracon ABX80X I2C ultra low power RTC/alarm chip
+
+maintainers:
+  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description:
+  The Abracon ABX80X family consists of the ab0801, ab0803, ab0804, ab0805,
+  ab1801, ab1803, ab1804 and ab1805. The ab0805 is the superset of ab080x and
+  the ab1805 is the superset of ab180x.
+
+properties:
+  compatible:
+    enum:
+      - abracon,abx80x    # Enables chip auto-detection
+      - abracon,ab0801
+      - abracon,ab0803
+      - abracon,ab0804
+      - abracon,ab0805
+      - abracon,ab1801
+      - abracon,ab1803
+      - abracon,ab1804
+      - abracon,ab1805
+      - microcrystal,rv1805
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  abracon,tc-diode:
+    description:
+      Select the series diode configuration for the trickle charger, between a
+      standard diode (0.6V) and a Schottky diode (0.3V).
+    enum: [standard, schottky]
+
+  abracon,tc-resistor:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Select the series output resistor value for the tricker charger, in kOhm.
+    enum: [0, 3, 6, 11]
+
+dependentRequired:
+  abracon,tc-diode: ["abracon,tc-resistor"]
+  abracon,tc-resistor: ["abracon,tc-diode"]
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: rtc.yaml#
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              enum:
+                - abracon,ab0804
+                - abracon,ab1804
+                - abracon,ab0805
+                - abracon,ab1805
+    then:
+      properties:
+        abracon,tc-diode: false
+        abracon,tc-resistor: false
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        rtc@69 {
+            compatible = "abracon,ab1805";
+            reg = <0x69>;
+            abracon,tc-diode = "schottky";
+            abracon,tc-resistor = <3>;
+        };
+    };
+...