[09/12] rtc: ds1511: remove partial alarm support

Message ID	20240227230431.1837717-9-alexandre.belloni@bootlin.com
State	Accepted
Headers	show Return-Path: <linux-rtc+bounces-746-incoming=patchwork.ozlabs.org@vger.kernel.org> From: alexandre.belloni@bootlin.com To: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/12] rtc: ds1511: remove partial alarm support Date: Wed, 28 Feb 2024 00:04:24 +0100 Message-ID: <20240227230431.1837717-9-alexandre.belloni@bootlin.com> In-Reply-To: <20240227230431.1837717-1-alexandre.belloni@bootlin.com> References: <20240227230431.1837717-1-alexandre.belloni@bootlin.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[01/12] rtc: ds1511: drop useless checks \| expand [01/12] rtc: ds1511: drop useless checks [02/12] rtc: ds1511: drop useless computation [03/12] rtc: ds1511: drop dead code [04/12] rtc: ds1511: drop useless enum [05/12] rtc: ds1511: fix function definition [06/12] rtc: ds1511: remove incomplete UIE support [07/12] rtc: ds1511: remove ds1511_rtc_update_alarm [08/12] rtc: ds1511: let the core know when alarm are not supported [09/12] rtc: ds1511: remove partial alarm support [10/12] rtc: ds1511: implement ds1511_rtc_read_alarm properly [11/12] rtc: ds1511: rename pdata [12/12] rtc: ds1511: drop inline/noinline hints

Message ID

20240227230431.1837717-9-alexandre.belloni@bootlin.com

State

Accepted

Headers

From: alexandre.belloni@bootlin.com
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/12] rtc: ds1511: remove partial alarm support
Date: Wed, 28 Feb 2024 00:04:24 +0100
Message-ID: <20240227230431.1837717-9-alexandre.belloni@bootlin.com>
In-Reply-To: <20240227230431.1837717-1-alexandre.belloni@bootlin.com>
References: <20240227230431.1837717-1-alexandre.belloni@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

[01/12] rtc: ds1511: drop useless checks | expand

Commit Message

Alexandre Belloni Feb. 27, 2024, 11:04 p.m. UTC

From: Alexandre Belloni <alexandre.belloni@bootlin.com>

The RTC core will always provide an alarm with all its members set, it is
not necessary to support partial alarms.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-ds1511.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c
index c81f464e6a50..d5d59a948c59 100644
--- a/drivers/rtc/rtc-ds1511.c
+++ b/drivers/rtc/rtc-ds1511.c
@@ -196,14 +196,10 @@  static int ds1511_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 		pdata->irqen |= RTC_AF;
 
 	spin_lock_irqsave(&pdata->lock, flags);
-	rtc_write(pdata->alrm_mday < 0 ? 0x80 : bin2bcd(pdata->alrm_mday) & 0x3f,
-	       DS1511_AM4_DATE);
-	rtc_write(pdata->alrm_hour < 0 ? 0x80 : bin2bcd(pdata->alrm_hour) & 0x3f,
-	       DS1511_AM3_HOUR);
-	rtc_write(pdata->alrm_min < 0 ? 0x80 : bin2bcd(pdata->alrm_min) & 0x7f,
-	       DS1511_AM2_MIN);
-	rtc_write(pdata->alrm_sec < 0 ? 0x80 : bin2bcd(pdata->alrm_sec) & 0x7f,
-	       DS1511_AM1_SEC);
+	rtc_write(bin2bcd(pdata->alrm_mday) & 0x3f, DS1511_AM4_DATE);
+	rtc_write(bin2bcd(pdata->alrm_hour) & 0x3f, DS1511_AM3_HOUR);
+	rtc_write(bin2bcd(pdata->alrm_min) & 0x7f, DS1511_AM2_MIN);
+	rtc_write(bin2bcd(pdata->alrm_sec) & 0x7f, DS1511_AM1_SEC);
 	ds1511_rtc_alarm_enable(alrm->enabled);
 
 	rtc_read(DS1511_CONTROL_A);	/* clear interrupts */

[09/12] rtc: ds1511: remove partial alarm support

Commit Message

Patch