| Message ID | 20221219190915.3912384-3-dennis@sparkcharge.io |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rtc: m41t80: set xtal load capacitance from DT | expand |
On 19/12/2022 20:09, Dennis Lambe Jr wrote: > The ST m41t82 and m41t83 support programmable load capacitance from 3.5 > pF to 17.4 pF. The hardware defaults to 12.5 pF. > > The accuracy of the xtal can be calibrated precisely by adjusting the > load capacicance. > > Add default, minimum, and maximum for the standard rtc property > quartz-load-femtofarads on compatible devices. > > Signed-off-by: Dennis Lambe Jr <dennis@sparkcharge.io> > --- > .../devicetree/bindings/rtc/st,m41t80.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > index fc9c6da6483f..6b72580dc031 100644 > --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml > @@ -33,6 +33,11 @@ properties: > "#clock-cells": > const: 1 > > + quartz-load-femtofarads: > + default: 12500 > + minimum: 3500 > + maximum: 17375 > + > clock-output-names: > maxItems: 1 > description: From common clock binding to override the default output clock name. > @@ -44,8 +49,21 @@ properties: > clock-frequency: > const: 32768 > > + wakeup-source: true Why do you need it here? It's already accepted in rtc.yaml. Adding it is not explained in commit msg. > + > allOf: Best regards, Krzysztof
On Tue, Dec 20, 2022 at 5:52 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > + wakeup-source: true > > Why do you need it here? It's already accepted in rtc.yaml. Adding it is > not explained in commit msg. This shouldn't have been included in the patch, my mistake. In the next revision of the patch series I'll take this line out. Sorry about that, thanks for catching it. Aside from that, does this patch look good to you? It passed dt_binding_check and reflects my understanding of the logic needed, but dt-binding yaml isn't something I'm super familiar with, especially the if: not: properties: contains: enum block. The intention is to indicate that the `quartz-load-femtofarads` property is only applicable to the m41t82 and m41t83, but not the other devices supported by the rtc-m41t80 driver.
diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml index fc9c6da6483f..6b72580dc031 100644 --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml @@ -33,6 +33,11 @@ properties: "#clock-cells": const: 1 + quartz-load-femtofarads: + default: 12500 + minimum: 3500 + maximum: 17375 + clock-output-names: maxItems: 1 description: From common clock binding to override the default output clock name. @@ -44,8 +49,21 @@ properties: clock-frequency: const: 32768 + wakeup-source: true + allOf: - $ref: rtc.yaml + - if: + not: + properties: + compatible: + contains: + enum: + - st,m41t82 + - st,m41t83 + then: + properties: + quartz-load-femtofarads: false unevaluatedProperties: false
The ST m41t82 and m41t83 support programmable load capacitance from 3.5 pF to 17.4 pF. The hardware defaults to 12.5 pF. The accuracy of the xtal can be calibrated precisely by adjusting the load capacicance. Add default, minimum, and maximum for the standard rtc property quartz-load-femtofarads on compatible devices. Signed-off-by: Dennis Lambe Jr <dennis@sparkcharge.io> --- .../devicetree/bindings/rtc/st,m41t80.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)