diff mbox series

[v2] rtc: rtc-spear: set range max

Message ID 20220728100101.1906801-1-zengjx95@gmail.com
State Accepted
Headers show
Series [v2] rtc: rtc-spear: set range max | expand

Commit Message

Zeng Jingxiang July 28, 2022, 10:01 a.m. UTC
From: Zeng Jingxiang <linuszeng@tencent.com>

In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65 
("rtc: spear: set range"), the value of 
RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
390	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
391	config->rtc->range_max = RTC_TIMESTAMP_END_9999;

Fixes: f395e1d3b28d ("rtc: spear: set range")
Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
---

Change in v2:
- Add fixes tag

 drivers/rtc/rtc-spear.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar July 28, 2022, 10:02 a.m. UTC | #1
On 28-07-22, 18:01, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <linuszeng@tencent.com>
> 
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65 
> ("rtc: spear: set range"), the value of 
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
> 
> Fixes: f395e1d3b28d ("rtc: spear: set range")
> Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---
> 
> Change in v2:
> - Add fixes tag
> 
>  drivers/rtc/rtc-spear.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
> index d4777b01ab22..736fe535cd45 100644
> --- a/drivers/rtc/rtc-spear.c
> +++ b/drivers/rtc/rtc-spear.c
> @@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
>  
>  	config->rtc->ops = &spear_rtc_ops;
>  	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> -	config->rtc->range_min = RTC_TIMESTAMP_END_9999;
> +	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>  
>  	status = devm_rtc_register_device(config->rtc);
>  	if (status)
> -- 
> 2.27.0
Alexandre Belloni Aug. 9, 2022, 11:47 a.m. UTC | #2
On Thu, 28 Jul 2022 18:01:01 +0800, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <linuszeng@tencent.com>
> 
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65
> ("rtc: spear: set range"), the value of
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
> 
> [...]

Applied, thanks!

[1/1] rtc: rtc-spear: set range max
      commit: 03c4cd6f89e074a51e289eb9129ac646f0f2bd29

Best regards,
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index d4777b01ab22..736fe535cd45 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -388,7 +388,7 @@  static int spear_rtc_probe(struct platform_device *pdev)
 
 	config->rtc->ops = &spear_rtc_ops;
 	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
-	config->rtc->range_min = RTC_TIMESTAMP_END_9999;
+	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
 
 	status = devm_rtc_register_device(config->rtc);
 	if (status)