diff mbox series

[v5,2/3] ARM: dts: nuvoton: Add nuvoton RTC3018Y node

Message ID 20220712030509.23904-3-mimi05633@gmail.com
State Superseded
Headers show
Series RTC: nuvoton: Add nuvoton real time clock driver | expand

Commit Message

Mia Lin July 12, 2022, 3:05 a.m. UTC 
Add nuvoton real time clock RTC3018Y in I2C node

Signed-off-by: Mia Lin <mimi05633@gmail.com>
---
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski July 12, 2022, 7:43 a.m. UTC | #1 
On 12/07/2022 05:05, Mia Lin wrote:
> Add nuvoton real time clock RTC3018Y in I2C node
> 
> Signed-off-by: Mia Lin <mimi05633@gmail.com>
> ---
>  arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> index 3dad32834e5e..589aadb67688 100644
> --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> @@ -202,6 +202,10 @@
>  		reg = <0x48>;
>  		status = "okay";
>  	};

Missing blank line.

> +	rtc0: rtc@6f {
> +		compatible = "nuvoton,nct3018y";
> +		reg = <0x6f>;
> +	};
>  };
>  
>  /* lm75 on EB */


Best regards,
Krzysztof
Mia Lin July 12, 2022, 9:28 a.m. UTC | #2 
Dear Krzysztof,

Thank you for your comment.
I will fill blank line.

Thanks.
Best Regards,
Mia

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年7月12日 週二 下午3:44寫道：
>
> On 12/07/2022 05:05, Mia Lin wrote:
> > Add nuvoton real time clock RTC3018Y in I2C node
> >
> > Signed-off-by: Mia Lin <mimi05633@gmail.com>
> > ---
> >  arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > index 3dad32834e5e..589aadb67688 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > @@ -202,6 +202,10 @@
> >               reg = <0x48>;
> >               status = "okay";
> >       };
>
> Missing blank line.
>
> > +     rtc0: rtc@6f {
> > +             compatible = "nuvoton,nct3018y";
> > +             reg = <0x6f>;
> > +     };
> >  };
> >
> >  /* lm75 on EB */
>
>
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
index 3dad32834e5e..589aadb67688 100644
--- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
+++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
@@ -202,6 +202,10 @@ 
 		reg = <0x48>;
 		status = "okay";
 	};
+	rtc0: rtc@6f {
+		compatible = "nuvoton,nct3018y";
+		reg = <0x6f>;
+	};
 };
 
 /* lm75 on EB */