| Message ID | 20220707153156.214841-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: cros-ec: Only warn once in .remove() about notifier_chain problems | expand |
On Thu, Jul 07, 2022 at 05:31:56PM +0200, Uwe Kleine-König wrote: > When a remove platform device callback returns an error code, the driver > core emits an error message ("remove callback returned a non-zero value. > This will be ignored.\n") and still removes the device. As the driver > already emits a more specific error message, return 0 to suppress the > core's error message. > > This is a preparation for making platform remove callbacks return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
On Thu, 7 Jul 2022 17:31:56 +0200, Uwe Kleine-König wrote: > When a remove platform device callback returns an error code, the driver > core emits an error message ("remove callback returned a non-zero value. > This will be ignored.\n") and still removes the device. As the driver > already emits a more specific error message, return 0 to suppress the > core's error message. > > This is a preparation for making platform remove callbacks return void. > > [...] Applied, thanks! [1/1] rtc: cros-ec: Only warn once in .remove() about notifier_chain problems commit: 5c9f41443e8d5fbd414ad0dfa8e0996b937d135a Best regards,
diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c index 70626793ca69..887f5193e253 100644 --- a/drivers/rtc/rtc-cros-ec.c +++ b/drivers/rtc/rtc-cros-ec.c @@ -375,10 +375,8 @@ static int cros_ec_rtc_remove(struct platform_device *pdev) ret = blocking_notifier_chain_unregister( &cros_ec_rtc->cros_ec->event_notifier, &cros_ec_rtc->notifier); - if (ret) { + if (ret) dev_err(dev, "failed to unregister notifier\n"); - return ret; - } return 0; }
When a remove platform device callback returns an error code, the driver core emits an error message ("remove callback returned a non-zero value. This will be ignored.\n") and still removes the device. As the driver already emits a more specific error message, return 0 to suppress the core's error message. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/rtc/rtc-cros-ec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56