| Message ID | 20220627080822.3881072-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next,v2] rtc: rv8803: fix missing unlock on error in rv8803_set_time() | expand |
On Mon, 27 Jun 2022 16:08:22 +0800, Yang Yingliang wrote: > Add the missing unlock before return from function rv8803_set_time() > in the error handling case. > > Applied, thanks! [1/1] rtc: rv8803: fix missing unlock on error in rv8803_set_time() commit: bb42b7e9e30e7a07b7cb6790a22dc758b0dc123e Best regards,
diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index fe1247e771b9..3527a0521e9b 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -315,8 +315,10 @@ static int rv8803_set_time(struct device *dev, struct rtc_time *tm) if (flags & RV8803_FLAG_V2F) { ret = rv8803_regs_reset(rv8803); - if (ret) + if (ret) { + mutex_unlock(&rv8803->flags_lock); return ret; + } } ret = rv8803_write_reg(rv8803->client, RV8803_FLAG,
Add the missing unlock before return from function rv8803_set_time() in the error handling case. Fixes: f8176e0bb83f ("rtc: rv8803: initialize registers on post-probe voltage loss") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de> --- v2: correct fix tag. --- drivers/rtc/rtc-rv8803.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)