diff mbox series

rtc: da9063: switch to RTC_FEATURE_UPDATE_INTERRUPT

Message ID 20211109234750.107115-1-alexandre.belloni@bootlin.com
State Accepted
Headers show
Series rtc: da9063: switch to RTC_FEATURE_UPDATE_INTERRUPT | expand

Commit Message

Alexandre Belloni Nov. 9, 2021, 11:47 p.m. UTC 
Stop using uie_unsupported and clear RTC_FEATURE_UPDATE_INTERRUPT instead.
Also, let the core know that the alarm will truncate seconds as it only has
a minute resolution.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-da9063.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Comments

Adam Thomson Nov. 18, 2021, 9:49 a.m. UTC | #1 
On 09 November 2021 23:48, Alexandre Belloni wrote

> Stop using uie_unsupported and clear RTC_FEATURE_UPDATE_INTERRUPT
> instead.
> Also, let the core know that the alarm will truncate seconds as it only has
> a minute resolution.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index d4b72a9fa2ba..54a5e244946b 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -475,12 +475,14 @@  static int da9063_rtc_probe(struct platform_device *pdev)
 	da9063_data_to_tm(data, &rtc->alarm_time, rtc);
 	rtc->rtc_sync = false;
 
-	/*
-	 * TODO: some models have alarms on a minute boundary but still support
-	 * real hardware interrupts. Add this once the core supports it.
-	 */
-	if (config->rtc_data_start != RTC_SEC)
-		rtc->rtc_dev->uie_unsupported = 1;
+	if (config->rtc_data_start != RTC_SEC) {
+		set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtc_dev->features);
+		/*
+		 * TODO: some models have alarms on a minute boundary but still
+		 * support real hardware interrupts.
+		 */
+		clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtc_dev->features);
+	}
 
 	irq_alarm = platform_get_irq_byname(pdev, "ALARM");
 	if (irq_alarm < 0)