| Message ID | 20210801160921.233081-4-romain.perier@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add RTC for MStar SoCs | expand |
Hi Romain, On Mon, 2 Aug 2021 at 01:09, Romain Perier <romain.perier@gmail.com> wrote: > +++ b/arch/arm/boot/dts/mstar-v7.dtsi > @@ -116,6 +116,13 @@ watchdog@6000 { > clocks = <&xtal_div2>; > }; > > + rtc@2400 { I think the rtc should be before the watchdog as the address is lower. I think maybe this got flipped around during cherry-picking. I can flip it around when I pull this into an mstar dts for 5.15 branch so you don't need to fix it and send a v3 assuming everything else is ok. Thanks, Daniel
Hi, As I need to send a v3, I can fix it, no worries. Cheers, Romain Le lun. 2 août 2021 à 12:40, Daniel Palmer <daniel@0x0f.com> a écrit : > > Hi Romain, > > On Mon, 2 Aug 2021 at 01:09, Romain Perier <romain.perier@gmail.com> wrote: > > +++ b/arch/arm/boot/dts/mstar-v7.dtsi > > @@ -116,6 +116,13 @@ watchdog@6000 { > > clocks = <&xtal_div2>; > > }; > > > > + rtc@2400 { > > I think the rtc should be before the watchdog as the address is lower. > I think maybe this got flipped around during cherry-picking. > I can flip it around when I pull this into an mstar dts for 5.15 > branch so you don't need to fix it and send a v3 assuming everything > else is ok. > > Thanks, > > Daniel
diff --git a/arch/arm/boot/dts/mstar-v7.dtsi b/arch/arm/boot/dts/mstar-v7.dtsi index 982dba9d28eb..1d4419aee67d 100644 --- a/arch/arm/boot/dts/mstar-v7.dtsi +++ b/arch/arm/boot/dts/mstar-v7.dtsi @@ -116,6 +116,13 @@ watchdog@6000 { clocks = <&xtal_div2>; }; + rtc@2400 { + compatible = "mstar,msc313-rtc"; + reg = <0x2400 0x40>; + clocks = <&xtal_div2>; + interrupts-extended = <&intc_irq GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; + }; + intc_fiq: interrupt-controller@201310 { compatible = "mstar,mst-intc"; reg = <0x201310 0x40>;
This adds the definition of the rtc device node. The RTC being able to work with the oscillator at 12Mhz for now, it shares the same xtal than the watchdog. Signed-off-by: Romain Perier <romain.perier@gmail.com> --- arch/arm/boot/dts/mstar-v7.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)