| Message ID | 20210716210437.29622-1-mat.jonczyk@o2.pl |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc-cmos: remove stale REVISIT comments | expand |
On Fri, 16 Jul 2021 23:04:37 +0200, Mateusz Jończyk wrote: > It appears mc146818_get_time() and mc146818_set_time() now correctly > use the century register as specified in the ACPI FADT table. It is not > clear what else could be done here. > > These comments were introduced by > commit 7be2c7c96aff ("[PATCH] RTC framework driver for CMOS RTCs") > in 2007, which originally referenced function get_rtc_time() in > include/asm-generic/rtc.h . > > [...] Applied, thanks! [1/1] rtc-cmos: remove stale REVISIT comments commit: e1aba37569f0aa9c993f740828871e48eea79f98 Best regards,
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 670fd8a2970e..eb15067a605e 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -229,19 +229,13 @@ static int cmos_read_time(struct device *dev, struct rtc_time *t) if (!pm_trace_rtc_valid()) return -EIO; - /* REVISIT: if the clock has a "century" register, use - * that instead of the heuristic in mc146818_get_time(). - * That'll make Y3K compatility (year > 2070) easy! - */ mc146818_get_time(t); return 0; } static int cmos_set_time(struct device *dev, struct rtc_time *t) { - /* REVISIT: set the "century" register if available - * - * NOTE: this ignores the issue whereby updating the seconds + /* NOTE: this ignores the issue whereby updating the seconds * takes effect exactly 500ms after we write the register. * (Also queueing and other delays before we get this far.) */
It appears mc146818_get_time() and mc146818_set_time() now correctly use the century register as specified in the ACPI FADT table. It is not clear what else could be done here. These comments were introduced by commit 7be2c7c96aff ("[PATCH] RTC framework driver for CMOS RTCs") in 2007, which originally referenced function get_rtc_time() in include/asm-generic/rtc.h . Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl> Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> --- drivers/rtc/rtc-cmos.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)