diff mbox series

rtc: v3020: remove redundant initialization of variable retval

Message ID 20210609120050.185746-1-colin.king@canonical.com
State Accepted
Headers show
Series rtc: v3020: remove redundant initialization of variable retval | expand

Commit Message

Colin Ian King June 9, 2021, noon UTC
From: Colin Ian King <colin.king@canonical.com>

The variable retval is being initialized with a value that is never read,
it is being updated later on. The assignment is redundant and can be
removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/rtc/rtc-v3020.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Belloni June 20, 2021, 8:33 p.m. UTC | #1
On Wed, 9 Jun 2021 13:00:50 +0100, Colin King wrote:
> The variable retval is being initialized with a value that is never read,
> it is being updated later on. The assignment is redundant and can be
> removed.

Applied, thanks!

[1/1] rtc: v3020: remove redundant initialization of variable retval
      commit: fc3c335226a92f69aa01061e66b60ace88475dd3

Best regards,
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c
index d2da92187d56..4e8341c49f51 100644
--- a/drivers/rtc/rtc-v3020.c
+++ b/drivers/rtc/rtc-v3020.c
@@ -282,7 +282,7 @@  static int rtc_probe(struct platform_device *pdev)
 {
 	struct v3020_platform_data *pdata = dev_get_platdata(&pdev->dev);
 	struct v3020 *chip;
-	int retval = -EBUSY;
+	int retval;
 	int i;
 
 	chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);