| Message ID | 20200317093922.20785-14-lkundrak@v3.sk |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | DT: Improve validation for Marvell SoCs | expand |
On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote: > These ports are compatible with NS8250 and handled by the same driver. > Get rid of the extra document that fails to document the properties that > are actually supported. Hi Lubmir This is needs a bit closer examination. By the PXA maintainers. It appears there are two serial drivers, the 8250 and a PXA specific driver. Andrew
On Tue, Mar 17, 2020 at 02:48:05PM +0100, Andrew Lunn wrote: > On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote: > > These ports are compatible with NS8250 and handled by the same driver. > > Get rid of the extra document that fails to document the properties that > > are actually supported. > > Hi Lubmir > > This is needs a bit closer examination. By the PXA maintainers. It > appears there are two serial drivers, the 8250 and a PXA specific > driver. Well, for "mrvl,mmp-uart", there are three: SERIAL_OF_PLATFORM, SERIAL_8250_PXA and SERIAL_PXA: drivers/tty/serial/8250/8250_of.c: { .compatible = "mrvl,mmp-uart", drivers/tty/serial/8250/8250_pxa.c: { .compatible = "mrvl,mmp-uart", }, drivers/tty/serial/pxa.c: { .compatible = "mrvl,mmp-uart", }, For that matter, the hardware is also compatible with intel,xscale-uart and the mrvl,mmp-uart compatible string is perhaps entirely unnecessary. I guess the story is somewhat similar for mrvl,pxa-uart; I can not verify though. I suppose SERIAL_PXA is not really needed at this point and if support for mrvl,pxa-uart was added to SERIAL_OF_PLATFORM, then SERIAL_8250_PXA would only be useful for platforms that don't use DT and the DT bits could be stripped from it eventually. That is -- if PXA maintainers agree, of course. > Andrew Regards Lubo
On Tue, Mar 17, 2020 at 7:48 AM Andrew Lunn <andrew@lunn.ch> wrote: > > On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote: > > These ports are compatible with NS8250 and handled by the same driver. > > Get rid of the extra document that fails to document the properties that > > are actually supported. > > Hi Lubmir > > This is needs a bit closer examination. By the PXA maintainers. It > appears there are two serial drivers, the 8250 and a PXA specific > driver. Yes, but that is independent of the binding. The PXA driver (serial/pxa.c) is already deprecated in favor of 8250_pxa.c. That was 3.5 years ago now, so maybe time to remove the old one. Rob
On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote: > > These ports are compatible with NS8250 and handled by the same driver. > Get rid of the extra document that fails to document the properties that > are actually supported. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > Documentation/devicetree/bindings/serial/8250.txt | 2 ++ > Documentation/devicetree/bindings/serial/mrvl-serial.txt | 4 ---- > 2 files changed, 2 insertions(+), 4 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/serial/mrvl-serial.txt Reviewed-by: Rob Herring <robh@kernel.org> I'd really like to see 8250.txt converted to schema. Rob
On Thu, Mar 19, 2020 at 10:11:02AM -0600, Rob Herring wrote: > On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote: > > > > These ports are compatible with NS8250 and handled by the same driver. > > Get rid of the extra document that fails to document the properties that > > are actually supported. > > > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > --- > > Documentation/devicetree/bindings/serial/8250.txt | 2 ++ > > Documentation/devicetree/bindings/serial/mrvl-serial.txt | 4 ---- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/serial/mrvl-serial.txt > > Reviewed-by: Rob Herring <robh@kernel.org> > > I'd really like to see 8250.txt converted to schema. I'll follow up just with that. Thanks quarantine. > Rob Lubo
diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt index 55700f20f6ee8..a543702859e2f 100644 --- a/Documentation/devicetree/bindings/serial/8250.txt +++ b/Documentation/devicetree/bindings/serial/8250.txt @@ -26,6 +26,8 @@ Required properties: - "aspeed,ast2400-vuart" - "aspeed,ast2500-vuart" - "nuvoton,npcm750-uart" + - "mrvl,mmp-uart" + - "mrvl,pxa-uart" - "serial" if the port type is unknown. - reg : offset and length of the register set for the device. - interrupts : should contain uart interrupt. diff --git a/Documentation/devicetree/bindings/serial/mrvl-serial.txt b/Documentation/devicetree/bindings/serial/mrvl-serial.txt deleted file mode 100644 index d744340de887c..0000000000000 --- a/Documentation/devicetree/bindings/serial/mrvl-serial.txt +++ /dev/null @@ -1,4 +0,0 @@ -PXA UART controller - -Required properties: -- compatible : should be "mrvl,mmp-uart" or "mrvl,pxa-uart".
These ports are compatible with NS8250 and handled by the same driver. Get rid of the extra document that fails to document the properties that are actually supported. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- Documentation/devicetree/bindings/serial/8250.txt | 2 ++ Documentation/devicetree/bindings/serial/mrvl-serial.txt | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) delete mode 100644 Documentation/devicetree/bindings/serial/mrvl-serial.txt