From patchwork Wed Dec 6 19:42:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Platschek X-Patchwork-Id: 845310 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ysTjh04wsz9s71 for ; Thu, 7 Dec 2017 06:50:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdLFTtn (ORCPT ); Wed, 6 Dec 2017 14:49:43 -0500 Received: from 178.115.242.59.static.drei.at ([178.115.242.59]:54094 "EHLO mail.osadl.at" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751604AbdLFTtl (ORCPT ); Wed, 6 Dec 2017 14:49:41 -0500 Received: by mail.osadl.at (Postfix, from userid 108) id B497A5C2FA7; Wed, 6 Dec 2017 19:42:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.osadl.at X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Received: from sunnyside.client.m3-hotspots.de (unknown [10.149.78.6]) by mail.osadl.at (Postfix) with ESMTP id 632C35C2E06; Wed, 6 Dec 2017 19:42:58 +0000 (UTC) From: Andreas Platschek To: linux-kernel@vger.kernel.org Cc: a.zummo@towertech.it, alexandre.belloni@free-electrons.com, linux-rtc@vger.kernel.org, Andreas Platschek Subject: [PATCH 1/2] rtc: omap: check for clk_prepare_enable() error Date: Wed, 6 Dec 2017 20:42:37 +0100 Message-Id: <20171206194238.12824-2-andreas.platschek@opentech.at> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171206194238.12824-1-andreas.platschek@opentech.at> References: <20171206194238.12824-1-andreas.platschek@opentech.at> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org clk_prepare_enable() returns an error -> check it. Signed-off-by: Andreas Platschek --- drivers/rtc/rtc-omap.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 1d666ac9ef70..ad309feb7d11 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -748,8 +748,15 @@ static int omap_rtc_probe(struct platform_device *pdev) else rtc->clk = devm_clk_get(&pdev->dev, "int-clk"); - if (!IS_ERR(rtc->clk)) - clk_prepare_enable(rtc->clk); + if (!IS_ERR(rtc->clk)) { + ret = clk_prepare_enable(rtc->clk); + if (ret) { + dev_err(&pdev->dev, + "Failed to enable rtc clk (%u)\n", ret); + return ret; + } + } + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); rtc->base = devm_ioremap_resource(&pdev->dev, res);