From patchwork Wed Sep 10 20:44:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 387970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x240.google.com (mail-ie0-x240.google.com [IPv6:2607:f8b0:4001:c03::240]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id F074F14011D for ; Thu, 11 Sep 2014 06:44:17 +1000 (EST) Received: by mail-ie0-f192.google.com with SMTP id rd18sf798777iec.19 for ; Wed, 10 Sep 2014 13:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=yAP83fD69D84FecBI0ZlAJYmLMV5oAKfkqg3oVWizjI=; b=xlvPazqY28vmJOBIs7k/BUScCKsoeF6fUitKBz/Q5K3sOdXIM8WX+DYNxuGmpK/ZW4 QjJ28g8PAilett0ZceG98RwNuNGafmZrvyEb6FwOUMy/9TUTdMvYhe4qFpQQZimdLQeN Lhl1YQeBkeMLJYcmvgWQ+LbrvDT0DeEiGVplx1AMs6k83Tns+Zx8vKq8OUYpBXAaDgEt eDy4AdtYtqXZE+QmpW6CWfcjGvqxwzdO6+L4KQILAiZuik+kiAj/5uBm78mHOguZYEL1 mCzM8DYcMTXJOR6Bwtc4dxfBf5QkfjYnuu6EvaSn9ankrMae9/NTOh/gukWLEe3v7FZT zmpA== X-Received: by 10.50.49.78 with SMTP id s14mr537606ign.7.1410381853503; Wed, 10 Sep 2014 13:44:13 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.142.100 with SMTP id rv4ls3505230igb.1.canary; Wed, 10 Sep 2014 13:44:13 -0700 (PDT) X-Received: by 10.70.92.137 with SMTP id cm9mr23190969pdb.4.1410381852978; Wed, 10 Sep 2014 13:44:12 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id pp6si577338pac.0.2014.09.10.13.44.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Sep 2014 13:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Received: from akpm3.mtv.corp.google.com (unknown [216.239.45.95]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CD04FA04; Wed, 10 Sep 2014 20:44:11 +0000 (UTC) Date: Wed, 10 Sep 2014 13:44:11 -0700 From: Andrew Morton To: Chris Zhong Cc: dianders@chromium.org, heiko@sntech.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it, mturquette@linaro.org, broonie@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, grant.likely@linaro.org, hl@rock-chips.com, huangtao@rock-chips.com, cf@rock-chips.com, zhangqing@rock-chips.com, xxx@rock-chips.com, olof@lixom.net, sonnyrao@chromium.org, dtor@chromium.org, javier.martinez@collabora.co.uk, kever.yang@rock-chips.com Subject: [rtc-linux] Re: [PATCH v10 1/3] RTC: RK808: add RTC driver for RK808 Message-Id: <20140910134411.8128acce79f2423d4448e8f4@linux-foundation.org> In-Reply-To: <1410311886-4579-2-git-send-email-zyw@rock-chips.com> References: <1410311886-4579-1-git-send-email-zyw@rock-chips.com> <1410311886-4579-2-git-send-email-zyw@rock-chips.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Original-Sender: akpm@linux-foundation.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) smtp.mail=akpm@linux-foundation.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wed, 10 Sep 2014 09:18:04 +0800 Chris Zhong wrote: > Adding RTC driver for supporting RTC device present inside RK808 PMIC. > > ... > > + ret = rtc_valid_tm(&tm); > + if (ret) { > + dev_warn(&pdev->dev, "invalid date/time and init time\n"); > + rk808_rtc_set_time(&pdev->dev, &tm_def); > + } This is somewhat unusual. Most drivers will emit a warning and give up when they find the time is wrong. Why is this driver different and is this desirable behaviour? Also, I did this: From: Andrew Morton Subject: rtc-rk808-add-rtc-driver-for-rk808-fix make tm_def static Cc: Chris Zhong Signed-off-by: Andrew Morton --- drivers/rtc/rtc-rk808.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff -puN drivers/rtc/Kconfig~rtc-rk808-add-rtc-driver-for-rk808-fix drivers/rtc/Kconfig diff -puN drivers/rtc/Makefile~rtc-rk808-add-rtc-driver-for-rk808-fix drivers/rtc/Makefile diff -puN drivers/rtc/rtc-rk808.c~rtc-rk808-add-rtc-driver-for-rk808-fix drivers/rtc/rtc-rk808.c --- a/drivers/rtc/rtc-rk808.c~rtc-rk808-add-rtc-driver-for-rk808-fix +++ a/drivers/rtc/rtc-rk808.c @@ -326,14 +326,14 @@ static SIMPLE_DEV_PM_OPS(rk808_rtc_pm_op rk808_rtc_suspend, rk808_rtc_resume); /* 2014.1.1 12:00:00 Saturday */ -struct rtc_time tm_def = { - .tm_wday = 6, - .tm_year = 114, - .tm_mon = 0, - .tm_mday = 1, - .tm_hour = 12, - .tm_min = 0, - .tm_sec = 0, +static struct rtc_time tm_def = { + .tm_wday = 6, + .tm_year = 114, + .tm_mon = 0, + .tm_mday = 1, + .tm_hour = 12, + .tm_min = 0, + .tm_sec = 0, }; static int rk808_rtc_probe(struct platform_device *pdev)