From patchwork Fri Dec 20 14:25:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 304097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ea0-x238.google.com (mail-ea0-x238.google.com [IPv6:2a00:1450:4013:c01::238]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 76EF82C00A5 for ; Sat, 21 Dec 2013 01:25:44 +1100 (EST) Received: by mail-ea0-f184.google.com with SMTP id b10sf187752eae.21 for ; Fri, 20 Dec 2013 06:25:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=date:from:to:cc:subject:message-id:references:mime-version :in-reply-to:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-disposition :content-transfer-encoding; bh=u3/rnLMRezYv2rN4LgHXpvSvoqagFhzIwjHLQIYIZSQ=; b=d6mZi3ZsyBVAyoopXfJrQUMzjd7B4Og4CD5AUrP2JHiwU8Mr8y/U/vdOuD3bTtGMCz d2qsEnupSni0atHvrthbLyeHnCZWPd4tdwl4CHp/sDjHck+tYsD9W28NN88lqQoHB+6a QooZJme9YGOo7+M0PRinsDflOT807SpM3Ku4t6pObkittYk4q9vVUZXUV6rKpCIVy593 Qv7d6MSwbzUjQCyDMEks4qSVoAB321PvGJl44peWTyQE7/AZmjmnqSxaGiCrDWEwsH0b ix9CBZBEWdLu95YvUF+AJD/RmYqWB2NodRXeT2ZcAIauXUkwRlZLu0lhLOWUWK1XEq+a XQtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:in-reply-to:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-disposition :content-transfer-encoding; bh=u3/rnLMRezYv2rN4LgHXpvSvoqagFhzIwjHLQIYIZSQ=; b=hubCQwHaBt5TnaDk7KovIh3BpW2KiTDYhBUXSN2Xpu7oZk2U4x39BwGqx7zRL0cuY4 /kvdUsxRM+o0+rSCUIqv4mzhkLPKKAMrNjNuwgWQbIQMVu8Tyq5oj3lyRtN9kUMBzmK1 ypzPJdepBb8iMjL2vfdopkuEml36vohxXM8++dK7Kwh5xYMGY3N8T9oWyUkBpqPWc7pI v6cd8Jq3tF+YZlBrD19trMQKsgWIwNigWVFPBKXpHvyr12plnfIukv97M6Yn2WGANKvi cqWZQLhgl3VzD+cuyvB+fAE1BL+DHl+k643LBp2Mwu1k3FOE5cPaBH5t881eS5GB1leX lsrg== X-Received: by 10.152.115.231 with SMTP id jr7mr3888lab.25.1387549539948; Fri, 20 Dec 2013 06:25:39 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.152.4.202 with SMTP id m10ls158809lam.92.gmail; Fri, 20 Dec 2013 06:25:39 -0800 (PST) X-Received: by 10.112.204.39 with SMTP id kv7mr3743021lbc.21.1387549539632; Fri, 20 Dec 2013 06:25:39 -0800 (PST) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gmr-mx.google.com with ESMTPS id e9si585511wix.2.2013.12.20.06.25.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Dec 2013 06:25:39 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.178 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) client-ip=209.85.212.178; Received: by mail-wi0-f178.google.com with SMTP id bz8so3758034wib.11 for ; Fri, 20 Dec 2013 06:25:39 -0800 (PST) X-Gm-Message-State: ALoCoQneKJtW1hZbQYDcF1EYLXwq0oM0MnTUkM5pjHqmHKmcGm6Q9OycOlJN9Sdf1RDO0Ijs2zHK X-Received: by 10.180.86.103 with SMTP id o7mr1529368wiz.6.1387549539472; Fri, 20 Dec 2013 06:25:39 -0800 (PST) Received: from lee--X1 ([213.205.236.32]) by mx.google.com with ESMTPSA id w1sm17691540wib.6.2013.12.20.06.25.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 20 Dec 2013 06:25:38 -0800 (PST) Date: Fri, 20 Dec 2013 14:25:30 +0000 From: Lee Jones To: Stephen Warren Cc: Samuel Ortiz , Alessandro Zummo , Andrew Morton , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com, Stephen Warren Subject: [rtc-linux] Re: [PATCH 1/3] mfd: always assign of_node in mfd_add_device() Message-ID: <20131220142530.GK3709@lee--X1> References: <1386626809-6251-1-git-send-email-swarren@wwwdotorg.org> <20131211092435.GC16780@lee--X1> <52B32C05.5010204@wwwdotorg.org> MIME-Version: 1.0 In-Reply-To: <52B32C05.5010204@wwwdotorg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 209.85.212.178 is neither permitted nor denied by best guess record for domain of lee.jones@linaro.org) smtp.mail=lee.jones@linaro.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline Hi Stephen, Please let me know if this is suitable and I can keep your Ack. ---- mfd: Revert "mfd: Always assign of_node in mfd_add_device()" This reverts commit 68044bee13770918e0b28dd44aa98c889ec7558f. We've had confirmed reports of this patch causing unforeseen issues with existing MFD users. It has been agreed by the original author and myself that reversion is the best solution. Acked-by: Stephen Warren Signed-off-by: Lee Jones diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index 32e8d47..2676492 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -117,8 +117,6 @@ static int mfd_add_device(struct device *parent, int id, } } } - if (!pdev->dev.of_node) - pdev->dev.of_node = parent->of_node; if (cell->pdata_size) { ret = platform_device_add_data(pdev,