| Message ID | 1615812674-62449-1-git-send-email-tiantao6@hisilicon.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag | expand |
On Mon, 15 Mar 2021 20:51:14 +0800, Tian Tao wrote: > request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable > because of requesting. Applied, thanks! [1/1] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag commit: 44db35cb9bf31163d17bee2c9748e1570b81be26 Best regards,
diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index a980337..0eb9a0d 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -268,11 +268,9 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) rtc->rtc->start_secs = mktime64(2009, 1, 1, 0, 0, 0); rtc->rtc->set_start_time = true; - irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN); - ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, tps6586x_rtc_irq, - IRQF_ONESHOT, + IRQF_ONESHOT | IRQF_NO_AUTOEN, dev_name(&pdev->dev), rtc); if (ret < 0) { dev_err(&pdev->dev, "request IRQ(%d) failed with ret %d\n",
request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- v2: Fix the problem of using wrong flags --- drivers/rtc/rtc-tps6586x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)