From patchwork Fri Nov 3 17:32:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akshay Bhat X-Patchwork-Id: 834029 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=timesys-com.20150623.gappssmtp.com header.i=@timesys-com.20150623.gappssmtp.com header.b="MJ4KWK8x"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yT8Ff65p8z9sBW for ; Sat, 4 Nov 2017 04:33:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756430AbdKCRdq (ORCPT ); Fri, 3 Nov 2017 13:33:46 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:43628 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756417AbdKCRdo (ORCPT ); Fri, 3 Nov 2017 13:33:44 -0400 Received: by mail-qt0-f193.google.com with SMTP id j58so4161769qtj.0 for ; Fri, 03 Nov 2017 10:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E5A7WXLf3Apn9Ki3RuoxUyrxpZH5lFjznybiPlz6gCQ=; b=MJ4KWK8x5UAi8HcscLdahzR3aSghggJtaO7NPVJ0hgN0hk4Uf2A5SoIUjYjJ95FTn/ 7PqlghGmKGesLFFyLip4jYWWAKhHLtmCyZBRgzjvs+2VAfuBPT2X/puM21N4nEifIKRi yPBIiecwV4dVmWphO74+dwU/7p3V2yD2YvOCR9hTq8NFJWKJMKJrDnzh3b7M/q/qg0+o 3vjomJ1Q6VDctOtafqw2tUzdMX9L13M9GG1GV3CfIQL9TdPzLIqdCBlOBTvD9kkaM0I5 xO7ov49+j9HK3zQcdu1IffP5CQl9WMh+x20G0ivjx+dV/ZlrrUVcy6JZgYVve8XsNl2Y NgYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E5A7WXLf3Apn9Ki3RuoxUyrxpZH5lFjznybiPlz6gCQ=; b=alV6yjaCJSgrwwD9mpJ1HQkebeYq4/CSY1rcytRvRhKow2j7K4MevOx0UW3fGTot2Y dw4Uk8xlWkWv10XcEBI4Pdvanf8JfOh9j40ro8n65EyrO9q7Xr4fzia4DvHL2Vl1g6f4 RRHArqlXfPWLejh8Iod8FTQCM+nSAl5zAkeYMO6H+usZIURuLnJlkv39b7GKFsZboNUc Xj3mSqgWP6AR469lYePRxG/kuBtbCpi3xUnnbG5mQYSrTcHGlg07WQpHDlwzMJE60fkS Ex6RkitZSJtLKl7OK8D5iYh5lwQUcJ8ZnoGNMv4XYHVtPjm5x8K+hqzwrhsyRWL9ORQR Dv+Q== X-Gm-Message-State: AMCzsaVgWqwqa/I9K2VouZzHEQQeMVJ1bXfT7p8B/XrPENiwSRe5zixY 035oz2cZIf2MXA8WmgT2mSLvCw== X-Google-Smtp-Source: ABhQp+S/NnJ8cEiuX+FXz0QYddYmM6QGx26igSiQaB/9YyHZS4vFbHxi2WxfCK5GJ5BMLOHyEowofQ== X-Received: by 10.200.42.11 with SMTP id k11mr11569005qtk.273.1509730424066; Fri, 03 Nov 2017 10:33:44 -0700 (PDT) Received: from timesysax.timesys.com (96-94-100-129-static.hfc.comcastbusiness.net. [96.94.100.129]) by smtp.gmail.com with ESMTPSA id n131sm4161188qke.48.2017.11.03.10.33.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Nov 2017 10:33:43 -0700 (PDT) From: Akshay Bhat To: a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Akshay Bhat Subject: [PATCH 3/3] rtc: rx8010: Fix for incorrect return value Date: Fri, 3 Nov 2017 13:32:41 -0400 Message-Id: <1509730361-23905-3-git-send-email-akshay.bhat@timesys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509730361-23905-1-git-send-email-akshay.bhat@timesys.com> References: <1509730361-23905-1-git-send-email-akshay.bhat@timesys.com> Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org The err variable is not being reset after a successful read. Explicitly reset err variable to account for all return paths. Reported-by: Jens-Peter Oswald Signed-off-by: Akshay Bhat --- drivers/rtc/rtc-rx8010.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c index 2e06e5f..1ce2078 100644 --- a/drivers/rtc/rtc-rx8010.c +++ b/drivers/rtc/rtc-rx8010.c @@ -223,6 +223,7 @@ static int rx8010_init_client(struct i2c_client *client) 2, ctrl); if (err != 2) return err < 0 ? err : -EIO; + err = 0; if (ctrl[0] & RX8010_FLAG_VLF) dev_warn(&client->dev, "Frequency stop was detected\n"); @@ -261,6 +262,7 @@ static int rx8010_read_alarm(struct device *dev, struct rtc_wkalrm *t) err = i2c_smbus_read_i2c_block_data(client, RX8010_ALMIN, 3, alarmvals); if (err != 3) return err < 0 ? err : -EIO; + err = 0; flagreg = i2c_smbus_read_byte_data(client, RX8010_FLAG); if (flagreg < 0)