| Message ID | 1467988422-17934-8-git-send-email-wens@csie.org |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi, On Fri, Jul 08, 2016 at 10:33:42PM +0800, Chen-Yu Tsai wrote: > The 32.768 kHz clock inside the A80 SoC is fed from an external source, > typically the AC100 RTC module. > > Make the osc32k placeholder a fixed-factor clock so board dts files can > specify its source. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > Changes since v4: none > Changes since v3: none > Changes since v2: none > Changes since v1: none > --- > arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 5 +++++ > arch/arm/boot/dts/sun9i-a80-optimus.dts | 5 +++++ > arch/arm/boot/dts/sun9i-a80.dtsi | 9 +++------ > 3 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts > index cf2f4b72a841..04b014603659 100644 > --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts > +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts > @@ -103,6 +103,11 @@ > allwinner,drive = <SUN4I_PINCTRL_40_MA>; > }; > > +&osc32k { > + /* osc32k input is from AC100 */ > + clocks = <&ac100_rtc 0>; > +}; > + I'm guessing that an unresolved dependency when the driver has not loaded yet, or is not even compiled ? How is it working then? Thanks, Maxime
On Mon, Jul 11, 2016 at 2:50 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Fri, Jul 08, 2016 at 10:33:42PM +0800, Chen-Yu Tsai wrote: >> The 32.768 kHz clock inside the A80 SoC is fed from an external source, >> typically the AC100 RTC module. >> >> Make the osc32k placeholder a fixed-factor clock so board dts files can >> specify its source. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> Changes since v4: none >> Changes since v3: none >> Changes since v2: none >> Changes since v1: none >> --- >> arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 5 +++++ >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 5 +++++ >> arch/arm/boot/dts/sun9i-a80.dtsi | 9 +++------ >> 3 files changed, 13 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >> index cf2f4b72a841..04b014603659 100644 >> --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >> +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >> @@ -103,6 +103,11 @@ >> allwinner,drive = <SUN4I_PINCTRL_40_MA>; >> }; >> >> +&osc32k { >> + /* osc32k input is from AC100 */ >> + clocks = <&ac100_rtc 0>; >> +}; >> + > > I'm guessing that an unresolved dependency when the driver has not > loaded yet, or is not even compiled ? > > How is it working then? I assume the clk framework will leave it unresolved and unusable. Also it seems that none of existing clks use it as a parent by default. I will need to check the remaining unimplemented ones though. ChenYu
On Tue, Jul 12, 2016 at 10:02 AM, Chen-Yu Tsai <wens@csie.org> wrote: > On Mon, Jul 11, 2016 at 2:50 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: >> Hi, >> >> On Fri, Jul 08, 2016 at 10:33:42PM +0800, Chen-Yu Tsai wrote: >>> The 32.768 kHz clock inside the A80 SoC is fed from an external source, >>> typically the AC100 RTC module. >>> >>> Make the osc32k placeholder a fixed-factor clock so board dts files can >>> specify its source. >>> >>> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >>> --- >>> Changes since v4: none >>> Changes since v3: none >>> Changes since v2: none >>> Changes since v1: none >>> --- >>> arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 5 +++++ >>> arch/arm/boot/dts/sun9i-a80-optimus.dts | 5 +++++ >>> arch/arm/boot/dts/sun9i-a80.dtsi | 9 +++------ >>> 3 files changed, 13 insertions(+), 6 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >>> index cf2f4b72a841..04b014603659 100644 >>> --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >>> +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts >>> @@ -103,6 +103,11 @@ >>> allwinner,drive = <SUN4I_PINCTRL_40_MA>; >>> }; >>> >>> +&osc32k { >>> + /* osc32k input is from AC100 */ >>> + clocks = <&ac100_rtc 0>; >>> +}; >>> + >> >> I'm guessing that an unresolved dependency when the driver has not >> loaded yet, or is not even compiled ? >> >> How is it working then? > > I assume the clk framework will leave it unresolved and unusable. > Also it seems that none of existing clks use it as a parent by > default. I will need to check the remaining unimplemented ones > though. On the latest sunxi-next kernel, one clock is clocked from osc32k, which becomes an orphaned clock: clock enable_cnt prepare_cnt rate accuracy phase ---------------------------------------------------------------------------------------- osc24M 6 6 24000000 0 0 r_ir 1 1 8000000 0 0 r_1wire 0 0 0 0 0 r_ir is clocked from osc32k by default, but the clk_set_rate call in the IR driver seems to forces it to reparent to the working osc24M clock. So I think we're good here. Can you merge the 3 remaining dts patches? Thanks ChenYu
diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts index cf2f4b72a841..04b014603659 100644 --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts @@ -103,6 +103,11 @@ allwinner,drive = <SUN4I_PINCTRL_40_MA>; }; +&osc32k { + /* osc32k input is from AC100 */ + clocks = <&ac100_rtc 0>; +}; + &pio { led_pins_cubieboard4: led-pins@0 { allwinner,pins = "PH6", "PH17"; diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts index e35c06c162a7..fd874ded890e 100644 --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts @@ -152,6 +152,11 @@ status = "okay"; }; +&osc32k { + /* osc32k input is from AC100 */ + clocks = <&ac100_rtc 0>; +}; + &pio { led_pins_optimus: led-pins@0 { allwinner,pins = "PH0", "PH1"; diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi index f68b3242b33a..dd11115ec087 100644 --- a/arch/arm/boot/dts/sun9i-a80.dtsi +++ b/arch/arm/boot/dts/sun9i-a80.dtsi @@ -148,15 +148,12 @@ /* * The 32k clock is from an external source, normally the - * AC100 codec/RTC chip. This clock is by default enabled - * and clocked at 32768 Hz, from the oscillator connected - * to the AC100. It is configurable, but no such driver or - * bindings exist yet. + * AC100 codec/RTC chip. This serves as a placeholder for + * board dts files to specify the source. */ osc32k: osc32k_clk { #clock-cells = <0>; - compatible = "fixed-clock"; - clock-frequency = <32768>; + compatible = "fixed-factor-clock"; clock-output-names = "osc32k"; };
The 32.768 kHz clock inside the A80 SoC is fed from an external source, typically the AC100 RTC module. Make the osc32k placeholder a fixed-factor clock so board dts files can specify its source. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- Changes since v4: none Changes since v3: none Changes since v2: none Changes since v1: none --- arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 5 +++++ arch/arm/boot/dts/sun9i-a80-optimus.dts | 5 +++++ arch/arm/boot/dts/sun9i-a80.dtsi | 9 +++------ 3 files changed, 13 insertions(+), 6 deletions(-)