From patchwork Mon Jun 20 13:55:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 637987 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-lf0-x237.google.com (mail-lf0-x237.google.com [IPv6:2a00:1450:4010:c07::237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rYC7V1k3Kz9t18 for ; Mon, 20 Jun 2016 23:56:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=QIAOpDko; dkim-atps=neutral Received: by mail-lf0-x237.google.com with SMTP id a4sf15057142lfa.0 for ; Mon, 20 Jun 2016 06:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=twBEX1tU5b15KYcNebfZrlAgrlh77kNGU9/IGqfbU00=; b=QIAOpDkoBSzUt/AimJzuFQLirgyhP3/i9uzznNPwzjhchdcbokFZr/OJdNChlAcIhU RxO2NAI7iAml2wvJ2Giy1MYq1y0xCQvoCfVKMJwbS8rySP7skGftNRmeDXN0agKfNtim 4MojLHqng96c1b/5cvGNs0tGXBmy/96lslYAkZt6BX1E4o2zYacY4q2pHJ9Cd0QUTK/0 IiJx1YRNYuXBkcS0XNv5WdHV4owcCilxtuo0bjZCmtS2rewxzIbtok51j6k1n/4I3mCz AOiZ5mC5CSOsQtQtwLyGu7hUusj7n7zE9E97kKzJGGPQ9cFbqHn7HPny91bQtJroIoKh YGCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=twBEX1tU5b15KYcNebfZrlAgrlh77kNGU9/IGqfbU00=; b=QN8SEYXznk262+tOymRKGvH+yAwZw4V/fKcOTxkitJia/jiz6CZbUgRAyWYfCYY2xF FtSbS9Eslkz2+iPK9Y2g9XcNKNnp9vqOeWF6iwCLNalAMiX6irMCPrHrN7Oqt8l9TOOz tHOWPl6ZbxPGDmiGqh1FYhFHXDOfvHUmFrLzfX3qQS2pNmYZk+qatSNeDtdIVsKn5nsQ 97+70emyZftXjTImLejLcelA5+RuRgIlQOmZ86nN0Fs1u+n1xzuxpKQnFlpoKgdGJ1VE iNISqU3vhIz7G0A0A+tjGlUr258ppdGENtsm0veZMVpV6rvMewY9yO2Kg+0J1sr3b7Rn /quQ== Sender: rtc-linux@googlegroups.com X-Gm-Message-State: ALyK8tJg9lzphgOmq0UR1ji0ELaGf1YDWSJyY5ja/iO3YuZTzra3+Vrq97iRMTr8Cw3g+Q== X-Received: by 10.46.32.161 with SMTP id g33mr120128lji.10.1466430963358; Mon, 20 Jun 2016 06:56:03 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.46.0.76 with SMTP id 73ls309041lja.74.gmail; Mon, 20 Jun 2016 06:56:02 -0700 (PDT) X-Received: by 10.46.0.20 with SMTP id 20mr3461023lja.9.1466430962837; Mon, 20 Jun 2016 06:56:02 -0700 (PDT) Received: from arcturus.kleine-koenig.org (arcturus.kleine-koenig.org. [78.47.169.190]) by gmr-mx.google.com with ESMTPS id a186si409584wma.1.2016.06.20.06.56.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 06:56:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of uwe@kleine-koenig.org designates 78.47.169.190 as permitted sender) client-ip=78.47.169.190; Received: by arcturus.kleine-koenig.org (Postfix, from userid 1000) id 76C12AC7EA; Mon, 20 Jun 2016 15:56:02 +0200 (CEST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Alessandro Zummo , Alexandre Belloni Cc: rtc-linux@googlegroups.com, =?UTF-8?q?Manuel=20R=C3=B6der?= Subject: [rtc-linux] [PATCH 4/5] rtc: s35390a: improve two comments in .set_alarm Date: Mon, 20 Jun 2016 15:55:52 +0200 Message-Id: <1466430953-18659-5-git-send-email-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1466430953-18659-1-git-send-email-uwe@kleine-koenig.org> References: <1466430953-18659-1-git-send-email-uwe@kleine-koenig.org> MIME-Version: 1.0 X-Original-Sender: uwe@kleine-koenig.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of uwe@kleine-koenig.org designates 78.47.169.190 as permitted sender) smtp.mailfrom=uwe@kleine-koenig.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Signed-off-by: Uwe Kleine-König --- drivers/rtc/rtc-s35390a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index 543a01509116..a37eeef9e247 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -266,12 +266,12 @@ static int s35390a_set_alarm(struct i2c_client *client, struct rtc_wkalrm *alm) alm->time.tm_min, alm->time.tm_hour, alm->time.tm_mday, alm->time.tm_mon, alm->time.tm_year, alm->time.tm_wday); - /* disable interrupt */ + /* disable interrupt (which deasserts the irq line) */ err = s35390a_set_reg(s35390a, S35390A_CMD_STATUS2, &sts, sizeof(sts)); if (err < 0) return err; - /* clear pending interrupt, if any */ + /* clear pending interrupt (in STATUS1 only), if any */ err = s35390a_get_reg(s35390a, S35390A_CMD_STATUS1, &sts, sizeof(sts)); if (err < 0) return err;