From patchwork Sun Apr 10 14:59:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 608526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-oi0-x23f.google.com (mail-oi0-x23f.google.com [IPv6:2607:f8b0:4003:c06::23f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qjbvl2q3Sz9snm for ; Mon, 11 Apr 2016 00:59:47 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=dEmPdZg/; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=hZKluEFL; dkim-atps=neutral Received: by mail-oi0-x23f.google.com with SMTP id w20sf29526527oie.0 for ; Sun, 10 Apr 2016 07:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=5HUldMRm5XVLWwDIS1GhveD8t2WXz7pBM6GCADRD+Qs=; b=dEmPdZg/ilsCuFAXbRPvaJi/UwiBBg5JExGZ/kyYP/jTBqc8Z4gRo1ygubeskujc0k m7MwJRzbHgtaJmuNFQm/AQXPa6ymHyU1aVlS9IWXgKujJ8XYLx7gGfaNvrcApg+dTvIo Oxy2lw9vZu4SUJn8DvYyMAQR+t5G8Dn2bmtf2GbF5SF47KTc1WWwtMcJ1lm1lW2z+c6A sdp7HjpqfzDzONxxheQ5QNSFmuiLGiRTc5/zqbGIPEQn/ygSYMieFwq9sUA1Pn+Nnefa 3wr9Snp6ueolSjRq/ijhusc8nAkTjTpg2BdwyylbK103ItseekpbTmDx8qJM2cerT2bA 3QYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=5HUldMRm5XVLWwDIS1GhveD8t2WXz7pBM6GCADRD+Qs=; b=hZKluEFLKwZDzmThRpmuh57d2Me33753cTbWCXeD1L7tqIM93xANIvgezO7QveUkF/ KNoNqwATnPeNSQEGYy1O94K4kpQ51KD/1qKCt6Zlk9xpm7p8RQCDRlGY3B0mLB5WJd/j HyVPWnZhSm6KZpB6xGDa6Ch9atTtSip4FE78AQyPTNr9ZUvM3st+o8+TzC114MwXbfab aXT3e8QuUNjXdi/XEYzIlBAVVtS8yVn2X0Es88HdDIBiKOFQrsSxnk1/gAoe87m4GsQx 6QLLIcKdUGFuqtGmEPCBNcjm6YkMZUb3iA9wKYWUsBYfLnElLnJTgN+e2mIQKx5yCKO0 2MGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=5HUldMRm5XVLWwDIS1GhveD8t2WXz7pBM6GCADRD+Qs=; b=gGmH9uOw/bkMEA1MlEpn0HTMMZZ9fMxQBB9uX34ZJJRsAcuH1XUbosjQREUbr9SZ5f i1b+onSpLheEH8z/y/UnnW+taaTmozV/gMrcxURcnzVCD/22voZPT8B7PzK9nnpEa/FB wnYhjEUT2twodCubr1x2AYuxw4u6XuEcZhigukNEk00cgAAE4N1wFIxj2ZMHbRROVgvq yAfT/iSsbbWQ6K7t97E8jL7Pp6e8+HJyQIQ4tetGchrB9HsW6rGCoeJlzj3WUsobGSjF pRmzeVlov4wisMm5MplyP4tctY7Equw9pI8ffiER31VjfEyD7O+X3J/o+lzdjI/IEsy4 OF6A== Sender: rtc-linux@googlegroups.com X-Gm-Message-State: AD7BkJJV6KWwoPYsAlB4A3vFdujQ8+6w14AfKl+Lm7xCI4PX7QY8yhoqglN5FCOiUwuSvA== X-Received: by 10.157.63.97 with SMTP id m88mr175104otc.12.1460300385625; Sun, 10 Apr 2016 07:59:45 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.182.129.129 with SMTP id nw1ls520778obb.68.gmail; Sun, 10 Apr 2016 07:59:45 -0700 (PDT) X-Received: by 10.157.38.179 with SMTP id l48mr11894836otb.26.1460300385261; Sun, 10 Apr 2016 07:59:45 -0700 (PDT) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com. [2607:f8b0:400e:c00::241]) by gmr-mx.google.com with ESMTPS id ph3si966875pac.1.2016.04.10.07.59.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Apr 2016 07:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of akinobu.mita@gmail.com designates 2607:f8b0:400e:c00::241 as permitted sender) client-ip=2607:f8b0:400e:c00::241; Received: by mail-pf0-x241.google.com with SMTP id d184so13072397pfc.1 for ; Sun, 10 Apr 2016 07:59:45 -0700 (PDT) X-Received: by 10.98.74.6 with SMTP id x6mr26398349pfa.80.1460300385101; Sun, 10 Apr 2016 07:59:45 -0700 (PDT) Received: from localhost.localdomain (KD113159139091.ppp-bb.dion.ne.jp. [113.159.139.91]) by smtp.gmail.com with ESMTPSA id lq10sm30302002pab.36.2016.04.10.07.59.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 10 Apr 2016 07:59:44 -0700 (PDT) From: Akinobu Mita To: rtc-linux@googlegroups.com, devicetree@vger.kernel.org Cc: Akinobu Mita , Sergey Yanovich , Alessandro Zummo , Alexandre Belloni Subject: [rtc-linux] [PATCH 1/4] rtc: ds1302: fix error check in set_time Date: Sun, 10 Apr 2016 23:59:23 +0900 Message-Id: <1460300366-25248-2-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> References: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> X-Original-Sender: Akinobu.Mita@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com; spf=pass (google.com: domain of akinobu.mita@gmail.com designates 2607:f8b0:400e:c00::241 as permitted sender) smtp.mailfrom=akinobu.mita@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The set_time callback for rtc-ds1302 doesn't write clock registers because the error check for the return value from spi_write_then_read() is not correct. spi_write_then_read() which returns zero on success. Signed-off-by: Akinobu Mita Cc: Sergey Yanovich Cc: Alessandro Zummo Cc: Alexandre Belloni --- drivers/rtc/rtc-ds1302.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c index 5cdc0f2..5e05653 100644 --- a/drivers/rtc/rtc-ds1302.c +++ b/drivers/rtc/rtc-ds1302.c @@ -54,7 +54,7 @@ static int ds1302_rtc_set_time(struct device *dev, struct rtc_time *time) status = spi_write_then_read(spi, buf, 2, NULL, 0); - if (!status) + if (status) return status; /* Write registers starting at the first time/date address. */