From patchwork Wed Dec 23 17:37:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 560673 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yk0-x23b.google.com (mail-yk0-x23b.google.com [IPv6:2607:f8b0:4002:c07::23b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0E3C514030F for ; Thu, 24 Dec 2015 04:37:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=YcNG5PDh; dkim-atps=neutral Received: by mail-yk0-x23b.google.com with SMTP id x184sf23796995yka.0 for ; Wed, 23 Dec 2015 09:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:x-original-sender :x-original-authentication-results:reply-to:content-type:precedence :mailing-list:list-id:x-spam-checked-in-group:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe; bh=sqDsWdMxjIqMYDRstc4t8hRITWmwetCzWKc7jV0mUqI=; b=YcNG5PDh7YckDeK2OJmC8c9eCLK7hZijHTeqA+iev6CpMcSs+9ADrYLa9ZyINXLyWN t+gvWWI08YD4Am0TR99OWrgAYGsBZcGe8+pn5AYEe+4eKr6m9JGoFzESUgm87czw4s+P xyWTChc/sDE1KeBMDzeHDdSbdyhIPM8HYWEPwj2BW/GEUfYYNdmksnOuPVt/9xKEetsH b7CE3XwSg7FpByZSuhah/wWCSoQZrKnz+9Zsa1Y9YtqfVkLUdArqqb6xRRwCBOgFWNDc ax+s2ppmaPY5Y5YwQmw1rkoi7+IRDdghkzkrzWlEyi82shnvK4J/pyz3uxsCWeWM+kOv Xcqw== X-Received: by 10.50.57.100 with SMTP id h4mr542549igq.6.1450892242856; Wed, 23 Dec 2015 09:37:22 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.110.69 with SMTP id hy5ls1752182igb.39.gmail; Wed, 23 Dec 2015 09:37:22 -0800 (PST) X-Received: by 10.107.152.208 with SMTP id a199mr27986001ioe.30.1450892242441; Wed, 23 Dec 2015 09:37:22 -0800 (PST) Received: from mga04.intel.com (mga04.intel.com. [192.55.52.120]) by gmr-mx.google.com with ESMTP id p88si3955907pfi.0.2015.12.23.09.37.22 for ; Wed, 23 Dec 2015 09:37:22 -0800 (PST) Received-SPF: pass (google.com: domain of andriy.shevchenko@linux.intel.com designates 192.55.52.120 as permitted sender) client-ip=192.55.52.120; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 23 Dec 2015 09:37:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,469,1444719600"; d="scan'208";a="879887567" Received: from black.fi.intel.com ([10.237.72.93]) by fmsmga002.fm.intel.com with ESMTP; 23 Dec 2015 09:37:21 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 43780B9; Wed, 23 Dec 2015 19:37:20 +0200 (EET) From: Andy Shevchenko To: Alexandre Belloni , rtc-linux@googlegroups.com Cc: Andy Shevchenko Subject: [rtc-linux] [PATCH v1 1/1] rtc: cmos: prevent kernel warning on IRQ flags mismatch Date: Wed, 23 Dec 2015 19:37:19 +0200 Message-Id: <1450892239-74224-1-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.6.4 X-Original-Sender: andriy.shevchenko@linux.intel.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andriy.shevchenko@linux.intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=andriy.shevchenko@linux.intel.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The Microsoft Surface 3 tablet shares interrupt line between RTC and one of SPI controllers. However, the rtc_cmos driver doesn't allow shared interrupts and user sees the following warning genirq: Flags mismatch irq 8. 00000080 (8086228E:02) vs. 00000000 (rtc0) ... [] pxa2xx_spi_probe+0x151/0x600 [spi_pxa2xx_platform] Allow RTC driver to use shared interrupts. Seems we are on the safe side to do just this simple change since cmos_interrupt() handler checks for the actual hardware status anyway. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-cmos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 8f7034b..84fb541 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -725,7 +725,7 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq) rtc_cmos_int_handler = cmos_interrupt; retval = request_irq(rtc_irq, rtc_cmos_int_handler, - 0, dev_name(&cmos_rtc.rtc->dev), + IRQF_SHARED, dev_name(&cmos_rtc.rtc->dev), cmos_rtc.rtc); if (retval < 0) { dev_dbg(dev, "IRQ %d is already in use\n", rtc_irq);