| Message ID | 1426586058-15987-2-git-send-email-k.kozlowski@samsung.com |
|---|---|
| State | Rejected |
| Headers | show |
On wto, 2015-03-17 at 10:54 +0100, Krzysztof Kozlowski wrote: > From: Chanwoo Choi <cw00.choi@samsung.com> > > This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is > equal to S2MPS14's RTC. > > Cc: Lee Jones <lee.jones@linaro.org> > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Tested on Exynos5433 board with S2MPS13 PMIC. Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> I feel like talking to myself with this self-reply... but at least this leaves a public track :). Best regards, Krzysztof
On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > On wto, 2015-03-17 at 10:54 +0100, Krzysztof Kozlowski wrote: > > From: Chanwoo Choi <cw00.choi@samsung.com> > > > > This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is > > equal to S2MPS14's RTC. > > > > Cc: Lee Jones <lee.jones@linaro.org> > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > Tested on Exynos5433 board with S2MPS13 PMIC. > Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > I feel like talking to myself with this self-reply... but at least this > leaves a public track :). If you are submitting a patch, it is assumed that you tested it _before_ sending.
On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > From: Chanwoo Choi <cw00.choi@samsung.com> > > This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is > equal to S2MPS14's RTC. > > Cc: Lee Jones <lee.jones@linaro.org> > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > Changes since v1: > 1. New patch. > --- > drivers/mfd/sec-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 0a7bc43db4e4..59bf322feacd 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -76,7 +76,7 @@ static const struct mfd_cell s2mps11_devs[] = { > > static const struct mfd_cell s2mps13_devs[] = { > { .name = "s2mps13-pmic", }, > - { .name = "s2mps13-rtc", }, > + { .name = "s2mps14-rtc", }, > { > .name = "s2mps13-clk", > .of_compatible = "samsung,s2mps13-clk",
2015-03-23 13:34 GMT+01:00 Lee Jones <lee.jones@linaro.org>: > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > >> From: Chanwoo Choi <cw00.choi@samsung.com> >> >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is >> equal to S2MPS14's RTC. >> >> Cc: Lee Jones <lee.jones@linaro.org> >> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> >> --- >> >> Changes since v1: >> 1. New patch. >> --- >> drivers/mfd/sec-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks. Hi, Sorry for the mess but we did this wrong. The S2MPS13 RTC is slightly different than S2MPS14 and that difference is important. It is embarrassing... but the difference was written small-print as a note in datasheet. Really. I found it after carefully comparing two PDFs. The impact of difference was not detected because of error in DTS for Exynos5433-based board. This patch should be dropped (or reverted) and "s2mps13-rtc" should be used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should have its own support for RTC which I will add in separate patch. Lee, once again sorry for the mess. How would you like to proceed? Can you just drop this commit? Best regards, Krzysztof
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote: > 2015-03-23 13:34 GMT+01:00 Lee Jones <lee.jones@linaro.org>: > > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > > > >> From: Chanwoo Choi <cw00.choi@samsung.com> > >> > >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is > >> equal to S2MPS14's RTC. > >> > >> Cc: Lee Jones <lee.jones@linaro.org> > >> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >> > >> --- > >> > >> Changes since v1: > >> 1. New patch. > >> --- > >> drivers/mfd/sec-core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. > > Hi, > > Sorry for the mess but we did this wrong. > The S2MPS13 RTC is slightly different than S2MPS14 and that difference > is important. It is embarrassing... but the difference was written > small-print as a note in datasheet. Really. I found it after carefully > comparing two PDFs. The impact of difference was not detected because > of error in DTS for Exynos5433-based board. > > This patch should be dropped (or reverted) and "s2mps13-rtc" should be > used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should > have its own support for RTC which I will add in separate patch. > > Lee, once again sorry for the mess. How would you like to proceed? Can > you just drop this commit? Patch removed -- panic averted.
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 0a7bc43db4e4..59bf322feacd 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -76,7 +76,7 @@ static const struct mfd_cell s2mps11_devs[] = { static const struct mfd_cell s2mps13_devs[] = { { .name = "s2mps13-pmic", }, - { .name = "s2mps13-rtc", }, + { .name = "s2mps14-rtc", }, { .name = "s2mps13-clk", .of_compatible = "samsung,s2mps13-clk",