From patchwork Thu Jul 24 15:17:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Donnefort X-Patchwork-Id: 373446 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wg0-x23e.google.com (mail-wg0-x23e.google.com [IPv6:2a00:1450:400c:c00::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 17F751401FB for ; Fri, 25 Jul 2014 01:17:58 +1000 (EST) Received: by mail-wg0-f62.google.com with SMTP id k14sf311225wgh.7 for ; Thu, 24 Jul 2014 08:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=xMpw97vgPnQFqy1B2tfL8HhQouP1mAHH3H3FM9XkWT4=; b=iKUhVPbL13cOfoExKXuk/oIlY2nsEGVWz3CedEV42JerCPl74htUOKO1JJZW5SQ4Ga JLWXXttCe3EMNwYAiUdWMFDt7baONNF0HeCRSTxKM8cwEJY5pxWBL7cxLWoACTt8i3aT gnJ+wY7SeYGVJgnlgOncRYCRS2Xu6eCBvJKecZRAqfjvEYcFyCxn0INu/R3TDQwEkJFf 7gdRi3+2yfUwpPmt1SkHYD/pUvfV9Elr0AhuE+7wnsa9RHkoyq7ZIGDe+v1CBX1bp4RH UNV76w8KwAdgn4qEA41wKzaPqMZ7GNRFCJBJUr8qITeratf3/mDp7mS7hL9DNTGdAmOJ njlQ== X-Received: by 10.180.13.129 with SMTP id h1mr118678wic.21.1406215074419; Thu, 24 Jul 2014 08:17:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.103.136 with SMTP id fw8ls329916wib.49.gmail; Thu, 24 Jul 2014 08:17:54 -0700 (PDT) X-Received: by 10.180.36.38 with SMTP id n6mr1096847wij.0.1406215073972; Thu, 24 Jul 2014 08:17:53 -0700 (PDT) Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com [2a00:1450:400c:c00::22b]) by gmr-mx.google.com with ESMTPS id b9si440216wic.2.2014.07.24.08.17.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 24 Jul 2014 08:17:53 -0700 (PDT) Received-SPF: pass (google.com: domain of vdonnefort@gmail.com designates 2a00:1450:400c:c00::22b as permitted sender) client-ip=2a00:1450:400c:c00::22b; Received: by mail-wg0-x22b.google.com with SMTP id l18so2795589wgh.2 for ; Thu, 24 Jul 2014 08:17:53 -0700 (PDT) X-Received: by 10.195.13.102 with SMTP id ex6mr12966151wjd.48.1406215073925; Thu, 24 Jul 2014 08:17:53 -0700 (PDT) Received: from localhost (200.5-14-84.ripe.coltfrance.com. [84.14.5.200]) by mx.google.com with ESMTPSA id f6sm16668017wja.25.2014.07.24.08.17.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Jul 2014 08:17:53 -0700 (PDT) From: Vincent Donnefort To: dan.carpenter@oracle.com, akpm@linux-foundation.org Cc: rtc-linux@googlegroups.com, Vincent Donnefort Subject: [rtc-linux] [PATCH] rtc: rtc-pcf8563: fix irq request Date: Thu, 24 Jul 2014 17:17:44 +0200 Message-Id: <1406215064-11296-2-git-send-email-vdonnefort@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1406215064-11296-1-git-send-email-vdonnefort@gmail.com> References: <20140724130952.GA29971@mwanda> <1406215064-11296-1-git-send-email-vdonnefort@gmail.com> X-Original-Sender: vdonnefort@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of vdonnefort@gmail.com designates 2a00:1450:400c:c00::22b as permitted sender) smtp.mail=vdonnefort@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , This patch fixes the irq request which was bypassed regardless of the device_register function return. Signed-off-by: Vincent Donnefort diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 98b35d2..5a197d9 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -419,7 +419,8 @@ static int pcf8563_probe(struct i2c_client *client, pcf8563_driver.driver.name, &pcf8563_rtc_ops, THIS_MODULE); - return PTR_ERR_OR_ZERO(pcf8563->rtc); + if (IS_ERR(pcf8563->rtc)) + return PTR_ERR(pcf8563->rtc); if (client->irq > 0) { err = devm_request_threaded_irq(&client->dev, client->irq,