From patchwork Fri Jul 4 01:22:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyogi Gim X-Patchwork-Id: 367006 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x240.google.com (mail-ie0-x240.google.com [IPv6:2607:f8b0:4001:c03::240]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 64FD2140076 for ; Fri, 4 Jul 2014 11:23:17 +1000 (EST) Received: by mail-ie0-f192.google.com with SMTP id rl12sf225563iec.19 for ; Thu, 03 Jul 2014 18:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=VI+0dxs2HOVGrBq9yJN0N2zNwzZuMais2dVAwYqOxls=; b=ore4Hc4SEfjfYaMpBDreZe9na0d4H742M4eGoa/noqThHS22zJmEd0OYbK6165DUG3 SMsiGmNIOQXWYscfqyDTAWSvSBFbz8uEuA29LdIJ6Q/mkTg9NXGZXNJ3R1F9uM+bpJoB tv1D5mSVyraIXjMZOHvil/ACHwx2awiv5/ic81LW4PDmWU9ZjV5HC3bEYFFFAgEqZFLR 5BV2nnQ5o6gfUXcqloQloNHq0b9RwVJpzsxYpK0Aj5ykEc4RIJ1HT8A/YkAwY526SElD EBzHunGmDDagmyWQNoHMbAY8hTNjJ7mizuF+RNvlZ5MbNgUVgc0y89ZH8G09e3FsXW86 lndg== X-Received: by 10.50.20.168 with SMTP id o8mr306542ige.12.1404436995778; Thu, 03 Jul 2014 18:23:15 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.114.202 with SMTP id ji10ls3810000igb.3.canary; Thu, 03 Jul 2014 18:23:15 -0700 (PDT) X-Received: by 10.43.114.138 with SMTP id fa10mr6442662icc.17.1404436995454; Thu, 03 Jul 2014 18:23:15 -0700 (PDT) Received: from lgemrelse7q.lge.com (LGEMRELSE7Q.lge.com. [156.147.1.151]) by gmr-mx.google.com with ESMTP id if8si6224932pad.2.2014.07.03.18.23.14 for ; Thu, 03 Jul 2014 18:23:15 -0700 (PDT) Received-SPF: pass (google.com: domain of hyogi.gim@lge.com designates 156.147.1.151 as permitted sender) client-ip=156.147.1.151; Received: from unknown (HELO localhost.localdomain) (165.186.175.61) by 156.147.1.151 with ESMTP; 4 Jul 2014 10:23:07 +0900 X-Original-SENDERIP: 165.186.175.61 X-Original-MAILFROM: hyogi.gim@lge.com From: Hyogi Gim To: Alessandro Zummo , John Stultz Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Hyogi Gim Subject: [rtc-linux] [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time() Date: Fri, 4 Jul 2014 10:22:26 +0900 Message-Id: <1404436946-28354-1-git-send-email-hyogi.gim@lge.com> X-Mailer: git-send-email 1.8.3.2 X-Original-Sender: hyogi.gim@lge.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of hyogi.gim@lge.com designates 156.147.1.151 as permitted sender) smtp.mail=hyogi.gim@lge.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , In __rtc_set_alarm(), the error after __rtc_read_time() is not checked. If rtc device fail to read time, we cannot guarantee the following process. Add the verification code for returned __rtc_read_time() error. Signed-off-by: Hyogi Gim --- drivers/rtc/interface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 5813fa5..5b2717f 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -348,6 +348,8 @@ static int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) /* Make sure we're not setting alarms in the past */ err = __rtc_read_time(rtc, &tm); + if (err) + return err; rtc_tm_to_time(&tm, &now); if (scheduled <= now) return -ETIME;