From patchwork Wed Aug 7 10:29:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laxman Dewangan X-Patchwork-Id: 265462 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qa0-x23a.google.com (mail-qa0-x23a.google.com [IPv6:2607:f8b0:400d:c00::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 76CC12C0257 for ; Wed, 7 Aug 2013 20:16:29 +1000 (EST) Received: by mail-qa0-f58.google.com with SMTP id cd7sf536266qab.23 for ; Wed, 07 Aug 2013 03:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=3uMhlPHkhMtrMbRAfUPvBby9sgN9qxTjpVwC7qjv8cc=; b=uTYoGS5sgxJ5Cukuo/i3OyIm14bFEbdp7+fi9sua4a1tQDeJiRxof6dlb3Tr9/YbW3 KY28uzHSAEo5f44Wwbwj54xnACQmBglwtHqXl7wz3jg+0Met1blmWW5SNUZDFYGMWCOS x12g+XnElYdlcdJKc/MJLbPunF7ejtST36PIKEkLYrFOBdS26z0xCaKMX11RFJCxJYpX W8JfwKrBGYq0vtNF92dMZI3Zv8TawNOb5JU+SBWv0Wlv0lllnUnHuOTNBttkr5lDytxo ntUPyo7qsB3hMhDlY0/X6ioJm49jhftx4b3KbhIzDR1+A8YqxgrHzTDGUUV7HoaASZG0 Evwg== X-Received: by 10.50.30.226 with SMTP id v2mr124038igh.17.1375870584832; Wed, 07 Aug 2013 03:16:24 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.132.9 with SMTP id oq9ls783873igb.6.gmail; Wed, 07 Aug 2013 03:16:24 -0700 (PDT) X-Received: by 10.66.219.33 with SMTP id pl1mr969607pac.37.1375870584335; Wed, 07 Aug 2013 03:16:24 -0700 (PDT) Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id tk8si1040016pab.2.2013.08.07.03.16.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 07 Aug 2013 03:16:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of ldewangan@nvidia.com designates 216.228.121.64 as permitted sender) client-ip=216.228.121.64; Received: from hqnvupgp07.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com id ; Wed, 07 Aug 2013 03:16:00 -0700 Received: from hqemhub02.nvidia.com ([172.20.12.94]) by hqnvupgp07.nvidia.com (PGP Universal service); Wed, 07 Aug 2013 03:16:23 -0700 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 07 Aug 2013 03:16:23 -0700 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by hqemhub02.nvidia.com (172.20.150.31) with Microsoft SMTP Server id 8.3.298.1; Wed, 7 Aug 2013 03:16:23 -0700 Received: from sc-daphne.nvidia.com (Not Verified[172.20.232.60]) by hqnvemgw01.nvidia.com with MailMarshal (v7,1,2,5326) id ; Wed, 07 Aug 2013 03:16:23 -0700 Received: from ldewangan-ubuntu.nvidia.com ([10.19.65.30]) by sc-daphne.nvidia.com (8.13.8+Sun/8.8.8) with ESMTP id r77AGF6b001977; Wed, 7 Aug 2013 03:16:16 -0700 (PDT) From: Laxman Dewangan To: CC: , , , , , , , , , , , , , , Laxman Dewangan Subject: [rtc-linux] [PATCH V4] drivers/rtc/rtc-palmas.c: support for backup battery charging Date: Wed, 7 Aug 2013 15:59:52 +0530 Message-ID: <1375871392-871-1-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 1.7.1.1 MIME-Version: 1.0 X-Original-Sender: ldewangan@nvidia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of ldewangan@nvidia.com designates 216.228.121.64 as permitted sender) smtp.mail=ldewangan@nvidia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Palmas series device like TPS65913, TPS80036 supports the backup battery for powering the RTC when no other energy source is available. The backup battery is optional, connected to the VBACKUP pin, and can be nonrechargeable or rechargeable. The rechargeable battery can be charged from the system supply using the backup battery charger. Add support for enabling charging of this backup battery. Also add the DT binding document and the new properties to have this support. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren Reviewed-by: Felipe Balbi --- Changes from V1: - Converted DT property to boolean. - cleanups as use "...". Changes from V2: - Correct the property name. Changes from V3: - Nit cleanups: properly capatilise the palmas to make it Palmas. - Added reviewed by of Felipe and Stephen. .../devicetree/bindings/rtc/rtc-palmas.txt | 29 ++++++++++++++++ drivers/rtc/rtc-palmas.c | 35 ++++++++++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt new file mode 100644 index 0000000..41bb445 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt @@ -0,0 +1,29 @@ +Palmas RTC controller bindings + +Required properties: +- compatible: + - "ti,palmas-rtc" for Palmas series of the RTC controller +- interrupt-parent: Parent interrupt device, must be handle of Palmas node. +- interrupts: Interrupt number of RTC submodule on device. + +Optional properties: +- ti,back-battery-charge-enable: The Palmas series device like TPS65913 or + TPS80036 supports the battery backup for powering the RTC when main + battery is removed or in very low power state. This flag will enable + the backup battery charging. +- ti,back-battery-charge-low-current: Configure lower charging current. Device + supports the charging current as < 100mA or >100mA. Low current will + set as <100mA. + +Example: + palmas: tps65913@58 { + ... + palmas_rtc: rtc { + compatible = "ti,palmas-rtc"; + interrupt-parent = <&palmas>; + interrupts = <8 0>; + ti,back-battery-charge-enable; + ti,back-battery-charge-low-current; + }; + ... + }; diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index a1fecc8..adb6e71 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c @@ -238,6 +238,15 @@ static int palmas_rtc_probe(struct platform_device *pdev) struct palmas *palmas = dev_get_drvdata(pdev->dev.parent); struct palmas_rtc *palmas_rtc = NULL; int ret; + bool enable_bb_charging = false; + bool low_bb_charging; + + if (pdev->dev.of_node) { + enable_bb_charging = of_property_read_bool(pdev->dev.of_node, + "ti,back-battery-charge-enable"); + low_bb_charging = of_property_read_bool(pdev->dev.of_node, + "ti,back-battery-charge-low-current"); + } palmas_rtc = devm_kzalloc(&pdev->dev, sizeof(struct palmas_rtc), GFP_KERNEL); @@ -254,6 +263,32 @@ static int palmas_rtc_probe(struct platform_device *pdev) palmas_rtc->dev = &pdev->dev; platform_set_drvdata(pdev, palmas_rtc); + if (enable_bb_charging) { + unsigned reg = 0; + + if (low_bb_charging) + reg |= PALMAS_BACKUP_BATTERY_CTRL_BBS_BBC_LOW_ICHRG; + + ret = palmas_update_bits(palmas, PALMAS_PMU_CONTROL_BASE, + PALMAS_BACKUP_BATTERY_CTRL, + PALMAS_BACKUP_BATTERY_CTRL_BBS_BBC_LOW_ICHRG, reg); + if (ret < 0) { + dev_err(&pdev->dev, + "BACKUP_BATTERY_CTRL update failed, %d\n", ret); + return ret; + } + + ret = palmas_update_bits(palmas, PALMAS_PMU_CONTROL_BASE, + PALMAS_BACKUP_BATTERY_CTRL, + PALMAS_BACKUP_BATTERY_CTRL_BB_CHG_EN, + PALMAS_BACKUP_BATTERY_CTRL_BB_CHG_EN); + if (ret < 0) { + dev_err(&pdev->dev, + "BACKUP_BATTERY_CTRL update failed, %d\n", ret); + return ret; + } + } + /* Start RTC */ ret = palmas_update_bits(palmas, PALMAS_RTC_BASE, PALMAS_RTC_CTRL_REG, PALMAS_RTC_CTRL_REG_STOP_RTC,