From patchwork Sun May 12 14:25:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 243185 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-fa0-x23e.google.com (mail-fa0-x23e.google.com [IPv6:2a00:1450:4001:c02::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A51302C00A7 for ; Mon, 13 May 2013 00:25:25 +1000 (EST) Received: by mail-fa0-f62.google.com with SMTP id m1sf1223953fae.7 for ; Sun, 12 May 2013 07:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=7/R5+TQhH+ysO0mRDbm3RE1MBzxwnJ78tSR0JfL0TLo=; b=tcRFBRq9AtzCFG86R8oi4VM6HKWukiGW/ZjQayY7LKFgJVs4hRWgWSvjd5hn80rkTX +Ie8bXWrxD/a/UXCHW1splSC+kohcmnnPM9wnGvXgEFbuil8YjLFwpA5MQIoUjA5PyGR 45gtUyBVGmj+cMKdICDyqLVpaZnHP//8yVpDFOugb7RI8sVUEXwGf1rb885EQzYOomn4 D00AmgDfhKswI/l6wroe7rlpDWh7pw4azY2/2+TYvk6ODEONlxdU/fVTtzTM1+iGwkn6 p853zVpCtZsRmo9wv5aZfTnQ+gdOEqinsYNm6suQxxwMag7YRkgVAghAsmExfJL5EnsL BuHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:from:to:cc:subject:date:message-id:x-mailer :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=7/R5+TQhH+ysO0mRDbm3RE1MBzxwnJ78tSR0JfL0TLo=; b=vJRvRRRTKai+X0ywTS9N2iK/VxLr5w8hgTWXXplHvitTl0Sv3Cz+8XtNGvFapC1jNk RIzINT8Rj6a9PrA2WIRScfvlv9EGc9UTqnqedrarhaX+HQ23WLShbs9I7rIqtDldJGDk 1B45VNmSUIa1epXJ6mstReD+7KLJ62aoNvKpdhuiRqYL015T834CGwGcC6m9l0mSy0dP mI1gyBEIg8PuCaX/UFv1ud7KCSgGVr0IRGD0KtFl9dLYi3ZPZXQLQe0A4qBZqZNk0Xqi NL67NpkIYeRuITMjT5SIS9Sgvq/e5WOogvWm8SlqSSqMTNg1r+hYSLgofliQ5ytKHrxe ftUg== X-Received: by 10.180.85.166 with SMTP id i6mr658431wiz.12.1368368721625; Sun, 12 May 2013 07:25:21 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.75.109 with SMTP id b13ls138628wiw.28.gmail; Sun, 12 May 2013 07:25:20 -0700 (PDT) X-Received: by 10.205.32.144 with SMTP id sk16mr4004625bkb.4.1368368720658; Sun, 12 May 2013 07:25:20 -0700 (PDT) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) by gmr-mx.google.com with ESMTPS id jh7si727141bkb.3.2013.05.12.07.25.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 12 May 2013 07:25:20 -0700 (PDT) Received-SPF: pass (google.com: domain of digetx@gmail.com designates 209.85.217.172 as permitted sender) client-ip=209.85.217.172; Received: by mail-lb0-f172.google.com with SMTP id y6so5602412lbh.17 for ; Sun, 12 May 2013 07:25:20 -0700 (PDT) X-Received: by 10.112.4.134 with SMTP id k6mr4635099lbk.24.1368368720450; Sun, 12 May 2013 07:25:20 -0700 (PDT) Received: from smtp.gmail.com:587 (ppp85-141-101-230.pppoe.mtu-net.ru. [85.141.101.230]) by mx.google.com with ESMTPSA id 2sm4087449lay.5.2013.05.12.07.25.18 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 12 May 2013 07:25:19 -0700 (PDT) Received: by smtp.gmail.com:587 (sSMTP sendmail emulation); Sun, 12 May 2013 18:25:17 +0400 From: Dmitry Osipenko To: a.zummo@towertech.it, akpm@linuxfoundation.org, ldewangan@nvidia.com Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Dmitry Osipenko Subject: [rtc-linux] [PATCH] rtc: tps6586x: device wakeup flags correction Date: Sun, 12 May 2013 18:25:06 +0400 Message-Id: <1368368706-21261-1-git-send-email-digetx@gmail.com> X-Mailer: git-send-email 1.8.2.1 X-Original-Sender: digetx@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of digetx@gmail.com designates 209.85.217.172 as permitted sender) smtp.mail=digetx@gmail.com; dkim=pass header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Use device_init_wakeup() instead of device_set_wakeup_capable() and move it before rtc dev registering. This fixes issue with alarmtimer that checks wakeup capability with device_may_wakeup() on device add. Signed-off-by: Dmitry Osipenko --- drivers/rtc/rtc-tps6586x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index 459c2ff..426901c 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -273,6 +273,8 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) return ret; } + device_init_wakeup(&pdev->dev, 1); + platform_set_drvdata(pdev, rtc); rtc->rtc = devm_rtc_device_register(&pdev->dev, dev_name(&pdev->dev), &tps6586x_rtc_ops, THIS_MODULE); @@ -292,7 +294,6 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) goto fail_rtc_register; } disable_irq(rtc->irq); - device_set_wakeup_capable(&pdev->dev, 1); return 0; fail_rtc_register: