From patchwork Thu Nov 8 13:45:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Song X-Patchwork-Id: 197839 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-oa0-f56.google.com (mail-oa0-f56.google.com [209.85.219.56]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 848382C0147 for ; Fri, 9 Nov 2012 00:47:15 +1100 (EST) Received: by mail-oa0-f56.google.com with SMTP id j6sf2042935oag.11 for ; Thu, 08 Nov 2012 05:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:x-originalarrivaltime :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type; bh=D6wUxfyUx41MYjCVn7pYacrU4Biu5QuybxSazkdLlBE=; b=aaUSfuwIBYHIW0PJxbWA3451ffwxzNZq/jpbV2vRT/mKB/Z0q/5CJObt9vb6EHizJp h7h3q7XZ4T5XsWcbsSdvBXmGWPC484mHcaYgWjsdwOjzDICgV807GjSflvK0HMbDqGjw KQfkIN4R82KhYxe3jxbGsoHQzkwPwa8ZnA50qTBjfQRRc/OWKcWe97hZ8RPxrVleFQX+ WqxjUYRfTOMroX31v71zTDw3erDq3Y9+OQO4sK0ipa5+X8IFwy45j/1yBdHqEpkrYxPk 7paUkP093hepUh11HgB1uk9fYFIoj4ZEzn5e8El0bvEusVAe9aPjA9x4jDCksCDrNzP6 h7vQ== Received: by 10.236.150.16 with SMTP id y16mr1262614yhj.8.1352382431976; Thu, 08 Nov 2012 05:47:11 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.101.212.13 with SMTP id o13ls620602anq.8.gmail; Thu, 08 Nov 2012 05:47:11 -0800 (PST) Received: by 10.66.87.73 with SMTP id v9mr3032971paz.46.1352382431554; Thu, 08 Nov 2012 05:47:11 -0800 (PST) Received: by 10.66.87.73 with SMTP id v9mr3032969paz.46.1352382431542; Thu, 08 Nov 2012 05:47:11 -0800 (PST) Received: from na3sys009aog124.obsmtp.com (na3sys009aog124.obsmtp.com [74.125.149.151]) by gmr-mx.google.com with SMTP id uz6si6156679pbc.0.2012.11.08.05.47.08 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Nov 2012 05:47:11 -0800 (PST) Received-SPF: neutral (google.com: 74.125.149.151 is neither permitted nor denied by best guess record for domain of liangs@marvell.com) client-ip=74.125.149.151; Received: from MSI-MTA.marvell.com ([65.219.4.132]) (using TLSv1) by na3sys009aob124.postini.com ([74.125.148.12]) with SMTP ID DSNKUJu33B7/Ok5MsGjaG0EJxSBuMAvR5Bnu@postini.com; Thu, 08 Nov 2012 05:47:10 PST Received: from maili.marvell.com ([10.68.76.210]) by MSI-MTA.marvell.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 8 Nov 2012 05:45:41 -0800 Received: from localhost (unknown [10.38.34.184]) by maili.marvell.com (Postfix) with ESMTP id E364C4E513; Thu, 8 Nov 2012 05:45:40 -0800 (PST) From: Leo Song To: Alessandro Zummo , Cc: Leo Song , Chao Xie Subject: [rtc-linux] [PATCH 2/3] rtc: pxa: fix alarm can't wake up system issue Date: Thu, 8 Nov 2012 21:45:32 +0800 Message-Id: <1352382333-13979-2-git-send-email-liangs@marvell.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1352382333-13979-1-git-send-email-liangs@marvell.com> References: <1352382333-13979-1-git-send-email-liangs@marvell.com> X-OriginalArrivalTime: 08 Nov 2012 13:45:41.0033 (UTC) FILETIME=[579F3990:01CDBDB7] X-Original-Sender: liangs@marvell.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 74.125.149.151 is neither permitted nor denied by best guess record for domain of liangs@marvell.com) smtp.mail=liangs@marvell.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , From: Leo Song fix alarm can't wake up system issue Change-Id: If14bc02712b14d2ad760bcc19b39a4bffee357a6 Signed-off-by: Leo Song diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c index 2695e55..dbc24e9 100644 --- a/drivers/rtc/rtc-pxa.c +++ b/drivers/rtc/rtc-pxa.c @@ -309,8 +309,6 @@ static int pxa_rtc_proc(struct device *dev, struct seq_file *seq) } static const struct rtc_class_ops pxa_rtc_ops = { - .open = pxa_rtc_open, - .release = pxa_rtc_release, .read_time = pxa_rtc_read_time, .set_time = pxa_rtc_set_time, .read_alarm = pxa_rtc_read_alarm, @@ -350,7 +348,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev) dev_err(dev, "No alarm IRQ resource defined\n"); goto err_ress; } - + pxa_rtc_open(dev); ret = -ENOMEM; pxa_rtc->base = ioremap(pxa_rtc->ress->start, resource_size(pxa_rtc->ress)); @@ -396,6 +394,9 @@ static int __exit pxa_rtc_remove(struct platform_device *pdev) { struct pxa_rtc *pxa_rtc = platform_get_drvdata(pdev); + struct device *dev = &pdev->dev; + pxa_rtc_release(dev); + rtc_device_unregister(pxa_rtc->rtc); spin_lock_irq(&pxa_rtc->lock);