From patchwork Mon Aug 23 15:05:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 62491 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-fx0-f56.google.com (mail-fx0-f56.google.com [209.85.161.56]) by ozlabs.org (Postfix) with ESMTP id A09A9B6EEA for ; Tue, 24 Aug 2010 01:07:02 +1000 (EST) Received: by fxm6 with SMTP id 6sf3404978fxm.11 for ; Mon, 23 Aug 2010 08:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:mime-version:x-beenthere:received :received:received:received:received-spf:received:from:to:cc:subject :date:message-id:x-mailer:x-sa-exim-connect-ip:x-sa-exim-mail-from :x-sa-exim-scanned:x-ptx-original-recipient:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=OFpqgBHsOUl/oXn2KoTAdzYyDgw8FTbMM4aYpAoZ5Jg=; b=N9/AgQPsLARLQdJ44VbFJr0vGWD1FvM61u/Akik2LoKBuDd62n8eIfKMTUOEHPOQs0 ldjfjggYZj2fVeH/wRw7tUzq+iG3Ljik/cTsduFNvOaTo9sO1yjOn2pBrB4WJThsUw0g GGnGPd+0TTQI/NDj0/apBlfST7ex6MnoM+EaU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:x-sa-exim-connect-ip:x-sa-exim-mail-from :x-sa-exim-scanned:x-ptx-original-recipient:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; b=CsTi8vGbO64oR3NzQgYiPlT3lkb04na/03ESAdB31XhawQa47AFa7UylaqJUaexsjG Jg1oTJoqXQbUDtacS/3WO86BYVNnIN5R8b3UVhKSkbVThOE/Pjl6YcUyQViE38oyfX66 GFIU7LAUHwNgmId3VG6YUDSnfRkL8R2iyUinA= Received: by 10.223.13.147 with SMTP id c19mr147081faa.36.1282576019565; Mon, 23 Aug 2010 08:06:59 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.223.32.142 with SMTP id c14ls1273735fad.2.p; Mon, 23 Aug 2010 08:06:59 -0700 (PDT) Received: by 10.223.119.130 with SMTP id z2mr289603faq.28.1282576018889; Mon, 23 Aug 2010 08:06:58 -0700 (PDT) Received: by 10.223.119.130 with SMTP id z2mr289602faq.28.1282576018865; Mon, 23 Aug 2010 08:06:58 -0700 (PDT) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [92.198.50.35]) by gmr-mx.google.com with ESMTP id l23si1770015fam.14.2010.08.23.08.06.58; Mon, 23 Aug 2010 08:06:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of w.sang@pengutronix.de designates 92.198.50.35 as permitted sender) client-ip=92.198.50.35; Received: from [2001:6f8:1178:2:221:70ff:fe71:1890] (helo=pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.71) (envelope-from ) id 1OnYbK-00030I-3v; Mon, 23 Aug 2010 17:06:18 +0200 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Jean Delvare , Wolfram Sang , Andrew Morton , Daniel Mack , Jonathan Cameron , Hemanth V , Liam Girdwood , Mark Brown , Sonic Zhang , Mike Frysinger , Marek Vasut , Paul Gortmaker , Alessandro Zummo , Roy Zang , Jingchang Lu , Mingkai Hu , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: [rtc-linux] [PATCH] i2c: remove obsolete cleanup for clientdata Date: Mon, 23 Aug 2010 17:05:08 +0200 Message-Id: <1282575908-16555-1-git-send-email-w.sang@pengutronix.de> X-Mailer: git-send-email 1.7.1 X-SA-Exim-Connect-IP: 2001:6f8:1178:2:221:70ff:fe71:1890 X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: rtc-linux@googlegroups.com X-Original-Sender: w.sang@pengutronix.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of w.sang@pengutronix.de designates 92.198.50.35 as permitted sender) smtp.mail=w.sang@pengutronix.de Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit. This is obsolete meanwhile, so fix it and hope the word will spread. Signed-off-by: Wolfram Sang Acked-by: Mark Brown --- Jean, I dunno if it fits for 2.6.36. It is not precisely a regression. Though, if it enters with the next merge window, the next set of "faulty" drivers may come in at the same time... drivers/misc/bh1780gli.c | 1 - drivers/regulator/ad5398.c | 1 - drivers/regulator/isl6271a-regulator.c | 2 -- drivers/rtc/rtc-ds3232.c | 2 -- 4 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/misc/bh1780gli.c b/drivers/misc/bh1780gli.c index 714c6b4..d5f3a3f 100644 --- a/drivers/misc/bh1780gli.c +++ b/drivers/misc/bh1780gli.c @@ -190,7 +190,6 @@ static int __devexit bh1780_remove(struct i2c_client *client) ddata = i2c_get_clientdata(client); sysfs_remove_group(&client->dev.kobj, &bh1780_attr_group); - i2c_set_clientdata(client, NULL); kfree(ddata); return 0; diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index d59d2f2..15ff61d 100644 --- a/drivers/regulator/ad5398.c +++ b/drivers/regulator/ad5398.c @@ -256,7 +256,6 @@ static int __devexit ad5398_remove(struct i2c_client *client) regulator_unregister(&chip->rdev); kfree(chip); - i2c_set_clientdata(client, NULL); return 0; } diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c index e49d2bd..65ecd82 100644 --- a/drivers/regulator/isl6271a-regulator.c +++ b/drivers/regulator/isl6271a-regulator.c @@ -191,8 +191,6 @@ static int __devexit isl6271a_remove(struct i2c_client *i2c) struct isl_pmic *pmic = i2c_get_clientdata(i2c); int i; - i2c_set_clientdata(i2c, NULL); - for (i = 0; i < 3; i++) regulator_unregister(pmic->rdev[i]); diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index 9daed8d..9de8516 100644 --- a/drivers/rtc/rtc-ds3232.c +++ b/drivers/rtc/rtc-ds3232.c @@ -268,7 +268,6 @@ out_irq: free_irq(client->irq, client); out_free: - i2c_set_clientdata(client, NULL); kfree(ds3232); return ret; } @@ -287,7 +286,6 @@ static int __devexit ds3232_remove(struct i2c_client *client) } rtc_device_unregister(ds3232->rtc); - i2c_set_clientdata(client, NULL); kfree(ds3232); return 0; }