| Message ID | 1282020249-8807-1-git-send-email-vapier@gentoo.org |
|---|---|
| State | Accepted |
| Headers | show |
bloop, should have included a summary item ... i cc-ed Andrew as my past experience is that RTC patches can squander for sometime ... patches 1 & 2 are important bugfixes that i'll punt over to the stable team once they get accepted. patches 3 & 4 can take the normal route to inclusion. -mike
On Tue, 17 Aug 2010 00:44:06 -0400 Mike Frysinger <vapier@gentoo.org> wrote: > The int_clear helper takes a bitmask of interrupts to keep, not to > disable. When suspending without wakeup enabled, we want to disable > all interrupts, so use 0 (keep none) instead of -1 (keep all). > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> Acked-by: Alessandro Zummo <a.zummo@towertech.it>
diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c index 72b2bcc..65facfb 100644 --- a/drivers/rtc/rtc-bfin.c +++ b/drivers/rtc/rtc-bfin.c @@ -426,7 +426,7 @@ static int bfin_rtc_suspend(struct platform_device *pdev, pm_message_t state) enable_irq_wake(IRQ_RTC); bfin_rtc_sync_pending(&pdev->dev); } else - bfin_rtc_int_clear(-1); + bfin_rtc_int_clear(0); return 0; }
The int_clear helper takes a bitmask of interrupts to keep, not to disable. When suspending without wakeup enabled, we want to disable all interrupts, so use 0 (keep none) instead of -1 (keep all). Signed-off-by: Mike Frysinger <vapier@gentoo.org> --- drivers/rtc/rtc-bfin.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)