From patchwork Wed Jan 7 08:22:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: matti.halme@nokia.com X-Patchwork-Id: 17066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from mail-gx0-f56.google.com (mail-gx0-f56.google.com [209.85.217.56]) by ozlabs.org (Postfix) with ESMTP id 9C51C47554 for ; Wed, 7 Jan 2009 19:22:46 +1100 (EST) Received: by gxk16 with SMTP id 16so10627999gxk.1 for ; Wed, 07 Jan 2009 00:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:received:x-sender:x-apparently-to :received:received:received-spf:authentication-results:received :received:received:x-mimeole:content-class:mime-version:content-type :subject:date:message-id:x-ms-has-attach:x-ms-tnef-correlator :thread-topic:thread-index:references:from:to:cc :x-originalarrivaltime:x-nokia-av:reply-to:sender:precedence :x-google-loop:mailing-list:list-id:list-post:list-help :list-unsubscribe:x-beenthere-env:x-beenthere; bh=fe40sp+9HMvJuxBKpLXmS+APv6KmFbd4RwNCNUWN2+k=; b=JU96gysA61hEakomsahOLp7rMoDzUFG3oN8rT2dkETGGbb3OPSH3GCPBCCqrjgixgh rX08HWlRa5VRWoDvISSIBp9ao5XxSSzYXau7Ju109r8Q3bOM4ASn8FR8J9hKRXTryaoF gRNoZHdBgI/5bHz/mZ6lVcL6jyIDCb3ymu3zQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-sender:x-apparently-to:received-spf:authentication-results :x-mimeole:content-class:mime-version:content-type:subject:date :message-id:x-ms-has-attach:x-ms-tnef-correlator:thread-topic :thread-index:references:from:to:cc:x-originalarrivaltime:x-nokia-av :reply-to:sender:precedence:x-google-loop:mailing-list:list-id :list-post:list-help:list-unsubscribe:x-beenthere-env:x-beenthere; b=tMRsWbLmws/KGmM6F40aEpdDxUeGeNcancjUJZCc70Hj7eX9BQePXjSrsKcOiGISNq Fhjdspd9CIn5CUCcOduHADKY3TFHswIgv/BEJ3UvG/ATkL0kA6ubM18qcA88b0fB+noL zG4qGScguRr5hn/gpx3k3AsVseYeGgbZVmvSA= Received: by 10.90.49.3 with SMTP id w3mr2434796agw.26.1231316561354; Wed, 07 Jan 2009 00:22:41 -0800 (PST) Received: by 10.230.24.165 with SMTP id v37gr1763vbb.0; Wed, 07 Jan 2009 00:22:41 -0800 (PST) X-Sender: matti.halme@nokia.com X-Apparently-To: rtc-linux@googlegroups.com Received: by 10.150.52.2 with SMTP id z2mr1272363ybz.3.1231316560637; Wed, 07 Jan 2009 00:22:40 -0800 (PST) Received: from mgw-mx03.nokia.com (smtp.nokia.com [192.100.122.230]) by mx.google.com with ESMTP id 22si6756071yxr.7.2009.01.07.00.22.39; Wed, 07 Jan 2009 00:22:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of matti.halme@nokia.com designates 192.100.122.230 as permitted sender) client-ip=192.100.122.230; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of matti.halme@nokia.com designates 192.100.122.230 as permitted sender) smtp.mail=matti.halme@nokia.com Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx03.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n078MP3J021888; Wed, 7 Jan 2009 10:22:38 +0200 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Jan 2009 10:22:26 +0200 Received: from vaebe107.NOE.Nokia.com ([10.160.244.68]) by vaebh104.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Jan 2009 10:22:26 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message Mime-Version: 1.0 Subject: [rtc-linux] [PATCH] Don't mask rtc-twl4030 alarm interrupts on shutdown Date: Wed, 7 Jan 2009 10:22:26 +0200 Message-ID: <043E6D9F43E2D14682729D3AE18163F3FD9B75@vaebe107.NOE.Nokia.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] Don't mask rtc-twl4030 alarm interrupts on shutdown Thread-Index: AclpxXLxFPC3FsaJQYegqe1hOBg6bgAvgb6yAAIPv3k= References: <043E6D9F43E2D14682729D3AE18163F3FD9B6C@vaebe107.NOE.Nokia.com> <043E6D9F43E2D14682729D3AE18163F3FD9B74@vaebe107.NOE.Nokia.com> From: To: , Cc: X-OriginalArrivalTime: 07 Jan 2009 08:22:26.0502 (UTC) FILETIME=[12D8E660:01C970A1] X-Nokia-AV: Clean Reply-To: rtc-linux@googlegroups.com Sender: rtc-linux@googlegroups.com Precedence: bulk X-Google-Loop: groups Mailing-List: list rtc-linux@googlegroups.com; contact rtc-linux+owner@googlegroups.com List-Id: List-Post: List-Help: List-Unsubscribe: , X-BeenThere-Env: rtc-linux@googlegroups.com X-BeenThere: rtc-linux@googlegroups.com A triggering RTC alarm should be able to power on a device that has been powered off. This patch enables that on twl4030 by not masking the alarm interrupt at shutdown. Signed-off-by: Matti Halme --- drivers/rtc/rtc-twl4030.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c index abe87a4..f5f6a97 100644 --- a/drivers/rtc/rtc-twl4030.c +++ b/drivers/rtc/rtc-twl4030.c @@ -505,8 +505,9 @@ static int __devexit twl4030_rtc_remove(struct platform_device *pdev) static void twl4030_rtc_shutdown(struct platform_device *pdev) { - mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M | - BIT_RTC_INTERRUPTS_REG_IT_ALARM_M); + /* mask timer interrupts, but leave alarm interrupts on to enable + power-on when alarm is triggered */ + mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M); } #ifdef CONFIG_PM