| Message ID | 03de7e5c04091b69c550be82420c6a8ce5bbb71f.1542630842.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: dt-binding: abx80x: fix resistance scale | expand |
On 19/11/2018 14:34:02+0200, Baruch Siach wrote: > The abracon,tc-resistor property value is in KOhm. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > index be789685a1c2..e668b5f65314 100644 > --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > @@ -27,4 +27,4 @@ and valid to enable charging: > > - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V) > - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output > - resistor, the other values are in ohm. > + resistor, the other values are in KOhm. The correct SI prefix is k so this should be kOhm. If you agree, I can fix this up.
Hi Alexandre, Alexandre Belloni writes: > On 19/11/2018 14:34:02+0200, Baruch Siach wrote: >> The abracon,tc-resistor property value is in KOhm. >> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> --- >> Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt >> index be789685a1c2..e668b5f65314 100644 >> --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt >> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt >> @@ -27,4 +27,4 @@ and valid to enable charging: >> >> - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V) >> - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output >> - resistor, the other values are in ohm. >> + resistor, the other values are in KOhm. > > The correct SI prefix is k so this should be kOhm. If you agree, I can > fix this up. I am fine with that. Please fix the commit message as well. Thanks, baruch
diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt index be789685a1c2..e668b5f65314 100644 --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt @@ -27,4 +27,4 @@ and valid to enable charging: - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V) - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output - resistor, the other values are in ohm. + resistor, the other values are in KOhm.
The abracon,tc-resistor property value is in KOhm. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)