From patchwork Fri May 3 06:35:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 241203 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yh0-x240.google.com (mail-yh0-x240.google.com [IPv6:2607:f8b0:4002:c01::240]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4624A2C00B0 for ; Fri, 3 May 2013 16:35:47 +1000 (EST) Received: by mail-yh0-f64.google.com with SMTP id b12sf379141yha.9 for ; Thu, 02 May 2013 23:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=RK2E9knOjRX3XdZbHJwGBp4Q1+mcraxAD9ZEA0glZWk=; b=ho/qKeM2hCOLj3+Z6cHJHqlldFsfmWKk7bTojefb+WQ8nOHhOV//a2gJTYIblP4xot xoLZtYcHIjYr6x2n3JNG8aTxHcg9ywfOLIKlEzYGxbeTdcMd5wG2WD7/GkzhBgqXy6r5 GgG/7ykiQjvuProDDDp4WVRDcpyeaAZpc9xPiGY+Z08HWbpOBKRBV0ySu0MEFUUMu9bT n+zWUNnoWbJUoWYr/s7aFAZoqk6amet9J+P5v5D/mWoG66KJRSXsAKYbTjm3XIb6/yuh KOSuDE/fewt7yLGsaxIGGnq/grOAXdpOD64E7AOK3cWsDz04p8hoF5YkG76HcRXvy3Hv aNug== X-Received: by 10.50.39.102 with SMTP id o6mr1413981igk.7.1367562944587; Thu, 02 May 2013 23:35:44 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.85.234 with SMTP id k10ls236226igz.42.canary; Thu, 02 May 2013 23:35:44 -0700 (PDT) X-Received: by 10.66.216.166 with SMTP id or6mr2826889pac.26.1367562943966; Thu, 02 May 2013 23:35:43 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id xb6si1784789pab.0.2013.05.02.23.35.43 for ; Thu, 02 May 2013 23:35:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM7003AEMBJ1A90@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:35:43 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 25.2D.04074.FBA53815; Fri, 03 May 2013 15:35:43 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-70-51835abf2858 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 39.8D.01422.EBA53815; Fri, 03 May 2013 15:35:42 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM7001GRMBI13B0@mmp1.samsung.com>; Fri, 03 May 2013 15:35:42 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, Jingoo Han Subject: [rtc-linux] [PATCH 30/42] rtc: rtc-pm8xxx: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:35:42 +0900 Message-id: <002c01ce47c8$6f518d90$4df4a8b0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyG6VNXiUEr0zR8+SVFn0hQqhRA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zQ939Uc2BBhNbmS2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKuH/0C3vBRY6KM4cOMzYwLmLvYuTkkBAwkTi7aC8bhC0mceHeeiCbi0NIYBmjREvX dmaYokXvlzFBJBYxShx984sdwvnFKHH20DYWkCo2ATWJL18OAyU4OEQE9CXaWjRAapgFuhkl HjXPBZskLBAs8XxfG9g6FgFViec3OsDqeQUsJRafSAUJ8woISvyYfA9sJLOAlsT6nceZIGx5 ic1r3kIdpCCx4+xrRhBbREBP4t3eh8wQNSIS+168Y4SoOcUu0f0mB2KVgMS3yYdYQFZJCMhK bDoANUZS4uCKGywTGMVmIdk8C8nmWUg2z0KyYQEjyypG0dSC5ILipPQiE73ixNzi0rx0veT8 3E2MkMibsIPx3gHrQ4zJQOsnMkuJJucDIzevJN7Q2MzIwtTE1NjI3NKMNGElcV71FutAIYH0 xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYymgT/Pc37n37nN0v3AOZkK14np0Vf332Vk8FWfen6b lEyc516XhrDwPY1+DiWPDnE1qd1rKjmj3f1PTTStxKirf9v5WTOeiWu+8dN8UadybGLG4VpX wTPyMVeaFCZk3EyxMfpjduXhn6SgcybW835Mjqqe9Uv2Rrx94ArfnoTKC7edZlu3dymxFGck GmoxFxUnAgCEqfWp0gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsVy+t9jAd19Uc2BBlc22lgsuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHH/6Bf2goscFWcOHWZsYFzE3sXIySEhYCKx 6P0yJghbTOLCvfVsXYxcHEICixgljr75xQ7h/GKUOHtoGwtIFZuAmsSXL4eBEhwcIgL6Em0t GiA1zALdjBKPmucyg9QICwRLPN/XxgZiswioSjy/0QFWzytgKbH4RCpImFdAUOLH5HtgI5kF tCTW7zzOBGHLS2xe85YZ4iAFiR1nXzOC2CICehLv9j5khqgRkdj34h3jBEaBWUhGzUIyahaS UbOQtCxgZFnFKJpakFxQnJSea6RXnJhbXJqXrpecn7uJERzZz6R3MK5qsDjEKMDBqMTDq9DS FCjEmlhWXJl7iFGCg1lJhNftB1CINyWxsiq1KD++qDQntfgQYzLQoxOZpUST84FJJ68k3tDY xMzI0sjMwsjE3Jw0YSVx3oOt1oFCAumJJanZqakFqUUwW5g4OKUaGLcZ2x7Nmnb3qrfQznaT tRJ+5c5bqw0W3ln8+8K10qdHe61Sf4ZuWyrw+1vfCm/JezKRs3+vU7OcEB4ozPR3i5/VIc47 zv8vN2xYZyrnr/dNYPaUO5/WtrsezeiQu7E4ZK9w1OVpC3ZMC5K4ljdbea2YbelHrQ2GSz48 UNouf8LYbn3gmdVdv8KUWIozEg21mIuKEwHf6jkWMAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-pm8xxx.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index f1a6557..14ee860 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -480,7 +480,6 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev) fail_req_irq: rtc_device_unregister(rtc_dd->rtc); fail_rtc_enable: - platform_set_drvdata(pdev, NULL); kfree(rtc_dd); return rc; } @@ -492,7 +491,6 @@ static int pm8xxx_rtc_remove(struct platform_device *pdev) device_init_wakeup(&pdev->dev, 0); free_irq(rtc_dd->rtc_alarm_irq, rtc_dd); rtc_device_unregister(rtc_dd->rtc); - platform_set_drvdata(pdev, NULL); kfree(rtc_dd); return 0;