Message ID | 002901ce47c8$1da1b010$58e51030$@samsung.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBNVURWGAKGQE3O7HQFY@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qa0-x23f.google.com (mail-qa0-x23f.google.com [IPv6:2607:f8b0:400d:c00::23f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E94F12C007C for <incoming@patchwork.ozlabs.org>; Fri, 3 May 2013 16:33:29 +1000 (EST) Received: by mail-qa0-f63.google.com with SMTP id o13sf95979qaj.18 for <incoming@patchwork.ozlabs.org>; Thu, 02 May 2013 23:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=wYYEJ7CiQFHxy0LIpXWI9UhgI5EwMZcfK5Pp0Ajxk94=; b=MPO1vDZHKbW3QpY+gSd6awsFxD5CnLd4OPjryrOIWCG7HRqScT+0IuMHtv6pE/UBa1 Ak+/ytDBVUWq3U115jFTAqV82TQOh52yfu5/YE1aKnGpRWcqtYtmJO1BQxNzR6oN54kM wSayEIHVVGy/12pxYd5roiXEXP4IULhRChrGM6jNRXUb4HzoBn188eE5USrVD0Ypdh5z 4n7E28IBIIRUanHGmsi898mQwmsUZBq2EMTexbIlyu6xocO4kyl1W/h150ripXi9+Jrz Gc2Oy8WaqYU7waIn2evH24dI2Fk8jHcm0c+BSK2cS+UvlfUrKmS8+dJaD0OYGUDyPoy/ hDRw== X-Received: by 10.50.101.39 with SMTP id fd7mr54948igb.16.1367562807182; Thu, 02 May 2013 23:33:27 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.56.238 with SMTP id d14ls228838igq.30.gmail; Thu, 02 May 2013 23:33:26 -0700 (PDT) X-Received: by 10.66.182.134 with SMTP id ee6mr3918372pac.0.1367562806772; Thu, 02 May 2013 23:33:26 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id gi6si1697807pbc.2.2013.05.02.23.33.26 for <rtc-linux@googlegroups.com>; Thu, 02 May 2013 23:33:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM70036WM7P1A90@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:33:25 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 7D.F6.19730.53A53815; Fri, 03 May 2013 15:33:25 +0900 (KST) X-AuditID: cbfee68e-b7efa6d000004d12-f2-51835a35c50c Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id CF.AC.01422.53A53815; Fri, 03 May 2013 15:33:25 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM700007M7PP4E0@mmp1.samsung.com>; Fri, 03 May 2013 15:33:25 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, Jingoo Han <jg1.han@samsung.com> Subject: [rtc-linux] [PATCH 27/42] rtc: rtc-mxc: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:33:25 +0900 Message-id: <002901ce47c8$1da1b010$58e51030$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5HyBzM9tIJOftdROqKIrZalUxImw== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t8zI13TqOZAg2tHdCyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKmPrhN0vBUs6KHxuXsTcwnmDvYuTkkBAwkZj44hMrhC0mceHeerYuRi4OIYFljBJr b+6GK9p4/BgLRGIRo8TWlx+hnF+MEjP3zWMCqWITUJP48uUwUAcHh4iAvkRbiwZIDbNAN6PE o+a5zCA1wgJ+Eo/a/oLVswioShxYf4UFxOYVsJSYdGMOK4QtKPFj8j2wOLOAlsT6nceZIGx5 ic1r3jJDXKQgsePsa0YQW0RAT+LY6xWsEDUiEvtevGMEWSwhcIxdYt7R+WwQywQkvk0+xAJy nISArMSmA1BzJCUOrrjBMoFRbBaS1bOQrJ6FZPUsJCsWMLKsYhRNLUguKE5KLzLSK07MLS7N S9dLzs/dxAiJvr4djDcPWB9iTAZaP5FZSjQ5Hxi9eSXxhsZmRhamJqbGRuaWZqQJK4nzqrVY BwoJpCeWpGanphakFsUXleakFh9iZOLglGpgrGgUfmhp9UqknL3vVwnj82PrWNc1m4l+0imp t4hkV2j15eYucQ4T2Z0Sdvy1/MP/BqVCHQseODZb99x4+MRLUGGl6q5N/ItquFWFGGRePm/K 51j/s/XbnscTfBbMXXHc66TQ49DbISVb73FOOR/5gfHFdY+Xnf9Mn7rWJNSKFMhXzT5YZcWv xFKckWioxVxUnAgAErH9ONQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jAV3TqOZAg7MvNCyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzJj64TdLwVLOih8bl7E3MJ5g72Lk5JAQMJHY ePwYC4QtJnHh3nq2LkYuDiGBRYwSW19+ZIFwfjFKzNw3jwmkik1ATeLLl8NA3RwcIgL6Em0t GiA1zALdjBKPmucyg9QIC/hJPGr7C1bPIqAqcWD9FbANvAKWEpNuzGGFsAUlfky+BxZnFtCS WL/zOBOELS+xec1bZoiLFCR2nH3NCGKLCOhJHHu9ghWiRkRi34t3jBMYBWYhGTULyahZSEbN QtKygJFlFaNoakFyQXFSeq6RXnFibnFpXrpecn7uJkZwbD+T3sG4qsHiEKMAB6MSD69CS1Og EGtiWXFl7iFGCQ5mJRFetx9AId6UxMqq1KL8+KLSnNTiQ4zJQJ9OZJYSTc4Hpp28knhDYxMz I0sjMwsjE3Nz0oSVxHkPtloHCgmkJ5akZqemFqQWwWxh4uCUamAUTSpO2rP10auvCZr2VbKX 79ZJLC15cqJEc5eMuPC03/dvWsn2hz+eutdl4uLKUq99HtIHeQ9Z8eVc/Ls6ySk36vnpvx2W jBWGTCInf70J/S5ylMWSQUo4pOHWQfe1pzNOvDZbv+XQnv25uzhXH2C+9+zccvHag4zBOo/1 I/gDelqChYsmZNxWYinOSDTUYi4qTgQA21kTzTEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c index 9a3895b..57192c7 100644 --- a/drivers/rtc/rtc-mxc.c +++ b/drivers/rtc/rtc-mxc.c @@ -443,15 +443,13 @@ static int mxc_rtc_probe(struct platform_device *pdev) THIS_MODULE); if (IS_ERR(rtc)) { ret = PTR_ERR(rtc); - goto exit_clr_drvdata; + goto exit_put_clk; } pdata->rtc = rtc; return 0; -exit_clr_drvdata: - platform_set_drvdata(pdev, NULL); exit_put_clk: clk_disable_unprepare(pdata->clk); @@ -465,7 +463,6 @@ static int mxc_rtc_remove(struct platform_device *pdev) struct rtc_plat_data *pdata = platform_get_drvdata(pdev); clk_disable_unprepare(pdata->clk); - platform_set_drvdata(pdev, NULL); return 0; }
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-mxc.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)