Message ID | 002601ce47c7$fb7a18b0$f26e4a10$@samsung.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBB7NTRWGAKGQEKAEHNJA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pb0-x23d.google.com (mail-pb0-x23d.google.com [IPv6:2607:f8b0:400e:c01::23d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 269D02C00B2 for <incoming@patchwork.ozlabs.org>; Fri, 3 May 2013 16:32:31 +1000 (EST) Received: by mail-pb0-f61.google.com with SMTP id rq8sf361737pbb.26 for <incoming@patchwork.ozlabs.org>; Thu, 02 May 2013 23:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=1pZvn0cluomptl55Rn579sd1tvLb3vw2k/IQGFFeZyg=; b=rFg1CPK8OzSnIZM4rUMt/wiIfGtjxBhKV/C6CMnOxQWAciludMc4CDN0bzyIL7gRp/ FTHOho9gwKQ4dtZC7rkkBs9h4PNLFytsPj56dp5WPtCkivxnt2SUgvlsIl2v62Niioqf cy6JglbzXkCAhI8bwBNZbjkOutNKAN5h9vhiqE/KCWRBbkw7gng6vNTmUMyZfcfv6WMq ERAlWptTGWVT5vSdzwJQ1cMS9eHNNLhyxZBOGzIbrpCiLMJB8CFCZZAW7FqY2bLXGLt0 b8SK5P08s/G8+bwB3S95NkvnsBmmbimIcUp2J2rmQZBHNO079CAQCdTGLXI8P0jxIfKd Tjzg== X-Received: by 10.50.128.105 with SMTP id nn9mr1400104igb.17.1367562749755; Thu, 02 May 2013 23:32:29 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.47.106 with SMTP id c10ls245041ign.0.canary; Thu, 02 May 2013 23:32:29 -0700 (PDT) X-Received: by 10.68.246.229 with SMTP id xz5mr3869692pbc.1.1367562749459; Thu, 02 May 2013 23:32:29 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id fn10si1784015pab.1.2013.05.02.23.32.29 for <rtc-linux@googlegroups.com>; Thu, 02 May 2013 23:32:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM70035UM641A90@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 03 May 2013 15:32:28 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 04.4B.31024.CF953815; Fri, 03 May 2013 15:32:28 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-d6-518359fc5df3 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A1.6C.08957.CF953815; Fri, 03 May 2013 15:32:28 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MM700MUFM641Y01@mmp2.samsung.com>; Fri, 03 May 2013 15:32:28 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, Jingoo Han <jg1.han@samsung.com> Subject: [rtc-linux] [PATCH 24/42] rtc: rtc-max8998: remove unnecessary platform_set_drvdata() Date: Fri, 03 May 2013 15:32:28 +0900 Message-id: <002601ce47c7$fb7a18b0$f26e4a10$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5Hx/rNFEQqbqjpRKyhwrztmfkeTA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zQ90/kc2BBu0bFC2WXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKePrlMlvBNM6Ka+/vsTQwnmDvYuTkkBAwkbjd+5UFwhaTuHBvPVsXIxeHkMAyRoln TfvhijpuLmSGSExnlLi5fwoLhPOLUeLwzEmsIFVsAmoSX74cBurg4BAR0Jdoa9EAqWEW6GaU eNQ8lxmkRlggRGLhwoWMIDaLgKrE0ZnbGEHqeQUsJdafByvhFRCU+DH5HthFzAJaEut3HmeC sOUlNq95ywxxkILEjrOvwcaICOhJbNp8iRmiRkRi34t3jBA1x9gltm/NglglIPFt8iEWkFUS ArISmw5AjZGUOLjiBssERrFZSDbPQrJ5FpLNs5BsWMDIsopRNLUguaA4Kb3IUK84Mbe4NC9d Lzk/dxMjJPJ6dzDePmB9iDEZaP1EZinR5Hxg5OaVxBsamxlZmJqYGhuZW5qRJqwkzqvWYh0o JJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgZHt0eHjKVeVSnrMQifHX0gXabFWOXbk7uvw4J7C nub/wnM0yidMULu++vjuu/cCFp1d/iwlZqJb7aWvf2NaYj/tvfP79cZAwYLXRqeOHDiRl/WK e9Me32V+jGL+0kq1rCmxi3mbl8afFDasjhBiC1p1x6ztmcOU3fF7XloFOCyRmzO/74Dy7Dol luKMREMt5qLiRADdzvV60gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsVy+t9jQd0/kc2BBncuyFosuXiV3WLO+jVs FpcXXmK1uLxrDpvF/s4ORgdWjz0TT7J5nJjxm8Wjb8sqRo/p834yeXzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmPH0y2W2gmmcFdfe32NpYDzB3sXIySEhYCLR cXMhM4QtJnHh3nq2LkYuDiGB6YwSN/dPYYFwfjFKHJ45iRWkik1ATeLLl8NA3RwcIgL6Em0t GiA1zALdjBKPmueCTRIWCJFYuHAhI4jNIqAqcXTmNkaQel4BS4n158FKeAUEJX5MvscCYjML aEms33mcCcKWl9i85i3UQQoSO86+BhsjIqAnsWnzJWaIGhGJfS/eMU5gFJiFZNQsJKNmIRk1 C0nLAkaWVYyiqQXJBcVJ6bmGesWJucWleel6yfm5mxjBkf1MagfjygaLQ4wCHIxKPLwKLU2B QqyJZcWVuYcYJTiYlUR43X4AhXhTEiurUovy44tKc1KLDzEmAz06kVlKNDkfmHTySuINjU3M jCyNzCyMTMzNSRNWEuc90GodKCSQnliSmp2aWpBaBLOFiYNTqoHxWGLURuWFL49uvG3PbDE9 VmHp2ojfNf1bFq6absnLY7fhi14TX3STXdD2NbkS81kfnz3g+ub+vMQ7R4TdvN2del8vZVDq qA2rXm8SP8tiy5ZbHe+XSwRuWBuiHJw9jeveysj3TrP4Os9+s5yzJKpsGsP0O8xXLxYneSRt nSMrx/I57q7Gjvw1SizFGYmGWsxFxYkAsws5RzADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
diff --git a/drivers/rtc/rtc-max8998.c b/drivers/rtc/rtc-max8998.c index 48b6612..b93842d 100644 --- a/drivers/rtc/rtc-max8998.c +++ b/drivers/rtc/rtc-max8998.c @@ -274,7 +274,7 @@ static int max8998_rtc_probe(struct platform_device *pdev) if (IS_ERR(info->rtc_dev)) { ret = PTR_ERR(info->rtc_dev); dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret); - goto out_rtc; + return ret; } ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL, @@ -292,10 +292,6 @@ static int max8998_rtc_probe(struct platform_device *pdev) } return 0; - -out_rtc: - platform_set_drvdata(pdev, NULL); - return ret; } static int max8998_rtc_remove(struct platform_device *pdev)
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-max8998.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)